Skip to content

fix: adjust bundling to not produce duplicate inlined internal modules #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged

fix: adjust bundling to not produce duplicate inlined internal modules #2774

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c54f7b
chore: add some validation to bundling to ensure we don't produce dup…
pieh Mar 17, 2025
3fbf588
chore: don't hardcode repo directory in build script
pieh Mar 17, 2025
14f2b98
test: adjust assertion for case where multiple cache-status values ar…
pieh Mar 17, 2025
93ef06a
Update tools/build.js
pieh Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: adjust assertion for case where multiple cache-status values ar… 
…e being comma separated and not line separated
  • Loading branch information
@pieh
pieh committed Mar 17, 2025
commit 14f2b9827fcd1949faf2f0f233d6ee1ee1e2e8b5
4 changes: 2 additions & 2 deletions tests/e2e/simple-app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ test('Renders the Home page correctly', async ({ page, simple }) => {

await expect(page).toHaveTitle('Simple Next App')

expect(headers['cache-status']).toMatch(/^"Next.js"; hit$/m)
expect(headers['cache-status']).toMatch(/^"Netlify Edge"; fwd=miss$/m)
expect(headers['cache-status'].replaceAll(', ', '\n')).toMatch(/^"Next.js"; hit$/m)
expect(headers['cache-status'].replaceAll(', ', '\n')).toMatch(/^"Netlify Edge"; fwd=miss$/m)
Comment on lines +15 to +16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to main portion of PR - seems like we might be getting comma separated cache-status values, so I'm massing it to have each statement as separate line to match regex assumption

// "Netlify Durable" assertion is skipped because we are asserting index page and there are possible that something else is making similar request to it
// and as a result we can see many possible statuses for it: `fwd=miss`, `fwd=miss; stored`, `hit; ttl=<ttl>` so there is no point in asserting on that
// "Netlify Edge" status suffers from similar issue, but is less likely to manifest (only if those requests would be handled by same CDN node) and retries
Expand Down
Loading