Skip to content

doc update for match_all_indexed removal #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2024
Merged

doc update for match_all_indexed removal #29

merged 1 commit into from
Jul 12, 2024

Conversation

taimingl
Copy link
Contributor

No description provided.

@taimingl taimingl requested a review from hengfeiyang July 12, 2024 05:01
@hengfeiyang
Copy link
Contributor

i think we need to do more, we simple replace the keyword, but we need to read it again, what is it? should we use match_all_raw or should guide user to user match_all.

@hengfeiyang hengfeiyang merged commit 8b4d0a2 into main Jul 12, 2024
@hengfeiyang hengfeiyang deleted the update-match-all branch July 12, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfeiyang hengfeiyang hengfeiyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taimingl @hengfeiyang