Skip to content

Fix default value of ZO_INGEST_FLATTEN_LEVEL #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IcarusSosie
Copy link
Contributor

According to the docs, ZO_INGEST_FLATTEN_LEVEL's default value is 5, but the default value in code is 3 :

    // [...]
    pub query_group_base_speed: usize,
    #[env_config(name = "ZO_INGEST_ALLOWED_UPTO", default = 5)] // in hours - in past
    pub ingest_allowed_upto: i64,
    #[env_config(name = "ZO_INGEST_FLATTEN_LEVEL", default = 3)] // default flatten level
    pub ingest_flatten_level: u32,
    #[env_config(name = "ZO_IGNORE_FILE_RETENTION_BY_STREAM", default = false)]
    pub ignore_file_retention_by_stream: bool,
    // [...]

This could lead to dataloss if a developer considers 5 to be enough according to the depth of their logs, but 3 wouldn't be.

Not totally unrelated, a list of BC breaks on release pages would be quite great 🥲.

@hengfeiyang
Copy link
Contributor

Thank you

@hengfeiyang hengfeiyang merged commit 2a69be7 into openobserve:main Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants