Skip to content

Conversation

@bwosborne2
Copy link
Contributor

Old version is unavailable

Signed-off-by: Bruce Osborne [email protected]

@cdjackson
Copy link
Contributor

@bwosborne2 we should try and keep separate PRs for different issues. Here you are mixing two things - the generator version, and you've also updated documentation. This means we can't merge anything until both are correct, and makes traceability a bit difficult since the PR doesn't mention docs.

I need to see if we can update to this version of the generator - it may not work. As I said elsewhere, we need to use a custom version of the generator to get some of the extra features included, and therefore I don't think that this will work fully with the latest public version.

Some of my changes were included into the master, but I think not all and I need to check if this is needed for the docs here.

@cdjackson
Copy link
Contributor

I've checked and v2.3 includes my changes, so this should be fine to merge.

@cdjackson cdjackson merged commit 03864ee into opensmarthouse:master Jan 9, 2021
@cdjackson
Copy link
Contributor

And thanks @bwosborne2

@bwosborne2
Copy link
Contributor Author

Sorry for the mix. I am still learning & did not expect that to happen. I am still learning but at least I can do signed PRs using VSCode now.

@cdjackson
Copy link
Contributor

No problem Bruce - thnaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants