-
Notifications
You must be signed in to change notification settings - Fork 309
fix(tree-menu): change the color of the dark mode icon #3457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the tree menu's styling by introducing a new CSS variable for icon fill color, applying flexbox layout to node names, and enhancing icon color behavior on hover and selection. These adjustments ensure consistent icon appearance and improved alignment within the tree menu component. Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request updates the styles for the tree menu component in dark mode. It introduces changes to the icon colors, ensuring they are consistent with the dark mode theme. The changes include setting the fill color for icons within the tree menu to enhance visual consistency. Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
packages/theme/src/tree-menu/vars.less (1)
34-40
:⚠️ Potential issueDeclare hover state icon color variable
The CSS inindex.less
references--tv-TreeMenu-node-icon-hover-color
, but this variable isn't declared here. Please add within the same block, for example:--tv-TreeMenu-node-icon-hover-color: var(--tv-color-icon-hover, #191919);to ensure hover styles apply correctly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/theme/src/tree-menu/index.less
(2 hunks)packages/theme/src/tree-menu/vars.less
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
packages/theme/src/tree-menu/vars.less (1)
34-36
: Introduce default node icon fill color variable
Adding--tv-TreeMenu-node-icon-fill-color
centralizes icon color theming with a sensible fallback.packages/theme/src/tree-menu/index.less (2)
213-215
: Align icons and text with flexbox
The newdisplay: flex; align-items: center;
on.tree-node-name
ensures icons and labels are vertically centered.
226-229
: Use centralized icon fill color
Applyingfill: var(--tv-TreeMenu-node-icon-fill-color)
ensures the default icon color is driven by your theme variable.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit