Skip to content

fix(tree-menu): change the color of the dark mode icon #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

wuyiping0628
Copy link
Collaborator

@wuyiping0628 wuyiping0628 commented May 24, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Improved alignment of tree menu node names with flexbox and vertical centering.
    • Enhanced icon color consistency by updating icon fill colors on hover and selection states.
    • Introduced a new variable for customizing tree menu node icon colors.

@wuyiping0628 wuyiping0628 added the bug Something isn't working label May 24, 2025
Copy link

coderabbitai bot commented May 24, 2025

Walkthrough

The changes update the tree menu's styling by introducing a new CSS variable for icon fill color, applying flexbox layout to node names, and enhancing icon color behavior on hover and selection. These adjustments ensure consistent icon appearance and improved alignment within the tree menu component.

Changes

File(s) Change Summary
packages/theme/src/tree-menu/index.less Enhanced .tree-node-name with flex layout; updated icon (svg) color handling for hover and selection states.
packages/theme/src/tree-menu/vars.less Added --tv-TreeMenu-node-icon-fill-color CSS variable for tree menu icon fill color.

Poem

In the forest of menus, where icons reside,
A flexy new layout lets them align with pride.
Their colors now shimmer, on hover and select,
With variables guiding the hues we expect.
A rabbit approves, with a hop and a cheer—
The tree’s looking sharp, from branch to ear! 🐇🌳

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Walkthrough

This pull request updates the styles for the tree menu component in dark mode. It introduces changes to the icon colors, ensuring they are consistent with the dark mode theme. The changes include setting the fill color for icons within the tree menu to enhance visual consistency.

Changes

File Summary
packages/theme/src/tree-menu/index.less Added CSS rules to set the fill color for SVG icons in various states, ensuring consistency in dark mode.
packages/theme/src/tree-menu/vars.less Introduced new CSS variables for icon fill colors to support the dark mode theme.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🔭 Outside diff range comments (1)
packages/theme/src/tree-menu/vars.less (1)

34-40: ⚠️ Potential issue

Declare hover state icon color variable
The CSS in index.less references --tv-TreeMenu-node-icon-hover-color, but this variable isn't declared here. Please add within the same block, for example:

--tv-TreeMenu-node-icon-hover-color: var(--tv-color-icon-hover, #191919);

to ensure hover styles apply correctly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1886a5d and c49f66f.

📒 Files selected for processing (2)
  • packages/theme/src/tree-menu/index.less (2 hunks)
  • packages/theme/src/tree-menu/vars.less (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
packages/theme/src/tree-menu/vars.less (1)

34-36: Introduce default node icon fill color variable
Adding --tv-TreeMenu-node-icon-fill-color centralizes icon color theming with a sensible fallback.

packages/theme/src/tree-menu/index.less (2)

213-215: Align icons and text with flexbox
The new display: flex; align-items: center; on .tree-node-name ensures icons and labels are vertically centered.


226-229: Use centralized icon fill color
Applying fill: var(--tv-TreeMenu-node-icon-fill-color) ensures the default icon color is driven by your theme variable.

@wuyiping0628 wuyiping0628 modified the milestone: 3414 May 24, 2025
@zzcr zzcr merged commit e8d537e into dev May 26, 2025
13 of 26 checks passed
@zzcr zzcr deleted the wyp/tree-menu-dark-bug-0524 branch May 26, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: 深色模式下树型菜单的图标颜色不会跟随主题变化
2 participants