Skip to content

fix(autocomplete): autocomplete component defaults to 100% of the width #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented May 27, 2025

PR

PR Checklist

autocomplete组件的宽度,默认就100%

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Updated autocomplete component styles to ensure it uses the full width of its container by default.
    • Minor formatting improvements for better readability; no impact on functionality.

Copy link

coderabbitai bot commented May 27, 2025

Walkthrough

The changes update the autocomplete component's styles in two theme packages. Both now ensure the root element takes the full width of its container by default. Minor formatting adjustments were made for compatibility and readability, but there are no changes to exported entities or component structure.

Changes

File(s) Change Summary
packages/theme-saas/src/autocomplete/index.less Added w-full to .autocomplete, reformatted IE10-11 media query, minor whitespace adjustments.
packages/theme/src/autocomplete/index.less Added width: 100% to the autocomplete root element.

Poem

A tweak to widths, a style refined,
Autocomplete now fits aligned.
Across the themes, a tidy sweep,
For every field, a promise to keep.
With CSS neat and bunnies proud,
Our forms stand tall, no shrinking allowed!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label May 27, 2025
Copy link

Walkthrough

This pull request modifies the autocomplete component to default its width to 100%. The changes involve updating the CSS to ensure the component occupies the full width by default.

Changes

Files Summary
packages/theme-saas/src/autocomplete/index.less, packages/theme/src/autocomplete/index.less Added styles to set the autocomplete component's width to 100% by default. Adjusted media query formatting for IE compatibility.

@@ -8,6 +8,7 @@
.@{autocomplete-prefix-cls} {
@apply relative;
@apply inline-block;
@apply w-full;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that applying w-full does not conflict with other styles or cause layout issues in different contexts.

@@ -18,6 +18,7 @@
.@{autocomplete-prefix-cls} {
position: relative;
display: inline-block;
width: 100%;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that setting width: 100% does not conflict with other styles or cause layout issues in different contexts.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/theme-saas/src/autocomplete/index.less (1)

34-35: Clarify media query consistency
The IE10–11 media query omits the screen qualifier in the second clause. Consider using screen and (-ms-high-contrast: none) for consistency and to avoid unintended matches.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between acf2d27 and 34dc0c8.

📒 Files selected for processing (2)
  • packages/theme-saas/src/autocomplete/index.less (4 hunks)
  • packages/theme/src/autocomplete/index.less (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (5)
packages/theme/src/autocomplete/index.less (2)

21-21: Add default full width to autocomplete root
Adding width: 100%; ensures the autocomplete component spans its container as intended.


79-79: The closing brace change is purely structural and introduces no functional differences.

packages/theme-saas/src/autocomplete/index.less (3)

11-11: Add default full width to autocomplete root
Using @apply w-full; aligns this theme with the updated default behavior of the autocomplete component.


74-74: The inserted blank line is a formatting adjustment with no impact on functionality.


114-114: This closing brace matches the file structure and is syntactically correct.

@zzcr zzcr merged commit 1d1324d into dev May 27, 2025
10 of 11 checks passed
@zzcr zzcr deleted the shen/add-select-single-slot branch May 27, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants