-
Notifications
You must be signed in to change notification settings - Fork 309
fix(autocomplete): autocomplete component defaults to 100% of the width #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the autocomplete component's styles in two theme packages. Both now ensure the root element takes the full width of its container by default. Minor formatting adjustments were made for compatibility and readability, but there are no changes to exported entities or component structure. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request modifies the autocomplete component to default its width to 100%. The changes involve updating the CSS to ensure the component occupies the full width by default. Changes
|
@@ -8,6 +8,7 @@ | |||
.@{autocomplete-prefix-cls} { | |||
@apply relative; | |||
@apply inline-block; | |||
@apply w-full; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that applying w-full
does not conflict with other styles or cause layout issues in different contexts.
@@ -18,6 +18,7 @@ | |||
.@{autocomplete-prefix-cls} { | |||
position: relative; | |||
display: inline-block; | |||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that setting width: 100%
does not conflict with other styles or cause layout issues in different contexts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme-saas/src/autocomplete/index.less (1)
34-35
: Clarify media query consistency
The IE10–11 media query omits thescreen
qualifier in the second clause. Consider usingscreen and (-ms-high-contrast: none)
for consistency and to avoid unintended matches.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/theme-saas/src/autocomplete/index.less
(4 hunks)packages/theme/src/autocomplete/index.less
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (5)
packages/theme/src/autocomplete/index.less (2)
21-21
: Add default full width to autocomplete root
Addingwidth: 100%;
ensures the autocomplete component spans its container as intended.
79-79
: The closing brace change is purely structural and introduces no functional differences.packages/theme-saas/src/autocomplete/index.less (3)
11-11
: Add default full width to autocomplete root
Using@apply w-full;
aligns this theme with the updated default behavior of the autocomplete component.
74-74
: The inserted blank line is a formatting adjustment with no impact on functionality.
114-114
: This closing brace matches the file structure and is syntactically correct.
PR
PR Checklist
autocomplete组件的宽度,默认就100%
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit