-
Notifications
You must be signed in to change notification settings - Fork 310
fix(dialog):fix dialog title line-height #3477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new line-height utility class Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Walkthrough此PR修复了对话框标题的行高问题,通过在样式文件中添加 Changes
|
@@ -73,6 +73,7 @@ | |||
@apply flex-1; | |||
@apply font-bold; | |||
@apply break-all; | |||
@apply ~'leading-5.5'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确保 @apply ~'leading-5.5';
的使用在所有目标浏览器中都能正常工作,因为某些浏览器可能不支持此类自定义属性。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme-saas/src/dialog-box/index.less (1)
76-76
: Ensure customleading-5.5
is defined and documented
Verify that the newleading-5.5
line-height utility is declared in your Tailwind configuration (undertheme.extend.lineHeight
) and update any style-guide or documentation so this class isn’t omitted in production builds.Consider unifying the quoting style for dynamic
@apply
classes to match existing patterns:- @apply ~'leading-5.5'; + @apply ~"leading-5.5";
PR
fix:对话框标题行高
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit