Skip to content

fix(select): modify the DOM structure of all options in the select to be consistent with that of the regular options to solve the text alignment issue #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented Jun 9, 2025

修改select的全部选项的dom结构和普通选项一致,以解决文本对齐的问题

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style

    • Improved formatting and standardized spacing in the select-dropdown component’s stylesheet.
    • Removed unused or commented-out CSS rules for cleaner styles.
  • Refactor

    • Updated the internal structure and class assignments for the "select all" option in dropdown lists, enhancing consistency in markup without changing visible behavior.

… be consistent with that of the regular options to solve the text alignment issue
Copy link

coderabbitai bot commented Jun 9, 2025

Walkthrough

This update introduces formatting changes to the LESS stylesheet for the select-dropdown component, standardizing spacing and removing unused CSS. Additionally, it restructures the HTML markup for the "select all" option in the Vue select component, wrapping the icon and label into separate containers with specific classes. No logic or exported entities are altered.

Changes

File(s) Change Summary
packages/theme-saas/src/select-dropdown/index.less Standardized spacing, cleaned up formatting, and removed unused/commented CSS; no logic changes.
packages/vue/src/select/src/pc.vue Refactored "select all" option markup: wrapped icon in <span>, label in <div> with new classes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SelectComponent
    participant Dropdown

    User->>SelectComponent: Opens dropdown (multiple select)
    SelectComponent->>Dropdown: Render options
    Dropdown->>Dropdown: Render "Select All" option
    Note right of Dropdown: Icon in <span>, label in <div>
    Dropdown->>User: Display updated dropdown structure
Loading

Poem

In the garden of code, a dropdown blooms anew,
With icons in spans and labels in view.
The stylesheet is tidy, the markup refined,
Like carrots in rows, all neatly aligned.
A hop and a skip, the changes are done—
Select all with style, and bugs there are none! 🥕✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/select/src/pc.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e33249 and b9280c2.

📒 Files selected for processing (2)
  • packages/theme-saas/src/select-dropdown/index.less (5 hunks)
  • packages/vue/src/select/src/pc.vue (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (7)
packages/vue/src/select/src/pc.vue (2)

499-504: Consistent dropdown option structure
The new wrapper <span> and <div> ensure that the "select all" option mirrors the regular item markup, resolving alignment discrepancies.


528-533: Aligned filtered "select all" option markup
The filtered variant now uses the same DOM structure as the primary option, eliminating inconsistent alignment.

packages/theme-saas/src/select-dropdown/index.less (5)

9-9: Introduce item prefix class variable
Defining @select-dropdown__item-prefix-cls centralizes the BEM prefix for dropdown items and supports the updated DOM structure.


40-46: Reset scroller item margins
Targeting the recycle-scroller wrapper and item prefix resets margin-right to zero, aligning items under the new structure.


47-51: Remove bottom margin on slot items
Clearing the default margin-bottom ensures uniform spacing for slot-based items in the dropdown.


92-95: Adjust icon vertical alignment
Tweaking the top margin on .tiny-svg elements corrects icon alignment within the option rows.


102-110: Standardize loading spinner styles
The loading state animations and sizing are updated for consistency; keyframe adjustments maintain the intended spinner behavior.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Jun 9, 2025
@shenjunjian shenjunjian requested review from MomoPoppy and removed request for MomoPoppy June 9, 2025 02:59
@zzcr zzcr merged commit 5ee3de3 into dev Jun 10, 2025
10 of 11 checks passed
@zzcr zzcr deleted the shen/select-all-dom-6.9 branch June 10, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants