-
Notifications
You must be signed in to change notification settings - Fork 309
fix(grid): add a border to the last row of the grid under the saas theme #3492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA CSS rule in the grid component's LESS stylesheet was updated, specifically adjusting the vertical position of a background image on the last row's columns. The background gradient line is now positioned at 97% from the top instead of 100%, moving it slightly upward. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme-saas/src/grid/table.less (1)
346-349
: Ensure consistent bottom border rendering for the last row
This adjustment shifts the second background gradient up by 3% so the border isn’t clipped by scrollbars or container padding. Please verify across different row heights and browser zoom levels that the line remains flush without visible gaps.
Consider adding a comment to clarify why97%
was chosen (versus something likecalc(100% - 1px)
) to improve maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/theme-saas/src/grid/table.less
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Parse Affected Components
- GitHub Check: Detect Changed Files
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit