-
Notifications
You must be signed in to change notification settings - Fork 309
fix(theme-saas): refresh theme-saas tailwind token #3523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe theme configuration file was updated to add a new fill color token, adjust the value of an existing icon color, introduce alias tokens for border radius under various UI elements, and modify the medium box shadow value with a new horizontal offset. All changes are confined to the theme JSON file. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/theme-saas/theme/theme.json (2)
49-49
: Add new fill color token
New tokencolor-fill-11
is added for light mode. Ensure the token is included in your CSS variable generation pipeline and that it’s documented in the theme spec.
930-938
: IntroducealiasToken
mappings for radius
Nice addition: alias tokens for buttons, cards, and other components improve semantic clarity. Ensure your build tooling supports the newaliasToken
structure and resolves these references correctly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/theme-saas/theme/theme.json
(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR Unit Test
🔇 Additional comments (5)
packages/theme-saas/theme/theme.json (5)
490-490
: Sync new fill token in dark mode
Dark mode now includescolor-fill-11
as well—good coordination across themes. Confirm the visual output matches design expectations on dark backgrounds.
72-72
: Update icon-secondary color in light mode
Changedcolor-icon-secondary
fromgray-500
togray-600
. Verify this meets your design specs and accessibility contrast ratios in light mode.
513-513
: Update icon-secondary color in dark mode
Changedcolor-icon-secondary
togray-600
for dark mode. Make sure the new shade provides sufficient contrast against dark backgrounds.
929-929
: ReviewborderRadius-full
value
The value"126.000rem"
for--tiny-borderRadius-full
is unusually large (≈2016px). Confirm this is intentional and works as expected for fully rounded corners.
986-986
: Adjust horizontal offset inboxShadow-md
Horizontal offset updated from0px
to1px
. Verify that this change aligns with the design mockups and doesn’t introduce unintended shadow clipping.
PR
刷新saas规范tailwind token
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Style