Skip to content

fix(theme-saas): refresh theme-saas tailwind token #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Conversation

gimmyhehe
Copy link
Member

@gimmyhehe gimmyhehe commented Jun 19, 2025

PR

刷新saas规范tailwind token

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Introduced a new fill color option for enhanced theme customization.
    • Added alias tokens for border radius, enabling consistent styling across various UI elements such as buttons, search, dropdowns, forms, cards, carousels, and tags.
  • Style

    • Updated the secondary icon color for improved visual clarity.
    • Adjusted the medium box shadow to include a horizontal offset for a refined appearance.

Copy link

coderabbitai bot commented Jun 19, 2025

Walkthrough

The theme configuration file was updated to add a new fill color token, adjust the value of an existing icon color, introduce alias tokens for border radius under various UI elements, and modify the medium box shadow value with a new horizontal offset. All changes are confined to the theme JSON file.

Changes

File Change Summary
packages/theme-saas/theme/theme.json Added fill color token, updated icon color value, added border radius alias tokens, modified box shadow value.

Poem

In the warren of themes, a new color appears,
Cool gray fills softly, while icons shift gears.
Borders find aliases—each button and tag,
Shadows now drift with a one-pixel swag.
A rabbit hops by, admiring the art—
Design in the details, a bright, hoppy start! 🐇🎨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Jun 19, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
packages/theme-saas/theme/theme.json (2)

49-49: Add new fill color token
New token color-fill-11 is added for light mode. Ensure the token is included in your CSS variable generation pipeline and that it’s documented in the theme spec.


930-938: Introduce aliasToken mappings for radius
Nice addition: alias tokens for buttons, cards, and other components improve semantic clarity. Ensure your build tooling supports the new aliasToken structure and resolves these references correctly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0959c6 and 6ec6320.

📒 Files selected for processing (1)
  • packages/theme-saas/theme/theme.json (6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR Unit Test
🔇 Additional comments (5)
packages/theme-saas/theme/theme.json (5)

490-490: Sync new fill token in dark mode
Dark mode now includes color-fill-11 as well—good coordination across themes. Confirm the visual output matches design expectations on dark backgrounds.


72-72: Update icon-secondary color in light mode
Changed color-icon-secondary from gray-500 to gray-600. Verify this meets your design specs and accessibility contrast ratios in light mode.


513-513: Update icon-secondary color in dark mode
Changed color-icon-secondary to gray-600 for dark mode. Make sure the new shade provides sufficient contrast against dark backgrounds.


929-929: Review borderRadius-full value
The value "126.000rem" for --tiny-borderRadius-full is unusually large (≈2016px). Confirm this is intentional and works as expected for fully rounded corners.


986-986: Adjust horizontal offset in boxShadow-md
Horizontal offset updated from 0px to 1px. Verify that this change aligns with the design mockups and doesn’t introduce unintended shadow clipping.

@zzcr zzcr merged commit 02e5624 into dev Jun 23, 2025
10 of 11 checks passed
@zzcr zzcr deleted the cgm/refresh-saas-token branch June 23, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants