Make code more rust idiomatic #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joeydelarago <[email protected]>
Signed-off-by: joeydelarago <[email protected]>
This makes no functional change, but is more idiomatic. Signed-off-by: joeydelarago <[email protected]>
Remove uses of val.as_str() for some String, this was being mixed with &val. Signed-off-by: joeydelarago <[email protected]>
Replace if -> else with match, this throws a compiler error when the enum is extended. It is handy for making sure all uses of the enum are updated. Signed-off-by: joeydelarago <[email protected]>
|
@Joeydelarago thank you for contribution! There should be some todos in the code itself, and #30 is still valid, I think. @Abdulbois @ashcherbakov anything in DSR's list so the community can help with? |
|
@Joeydelarago thank you for contribution! LGTM Will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a read through the project and had some small suggestions.
I couldn't find a todo list, is there one hosted somewhere? I was thinking of contributing to the project in a more meaningful way that style changes.