Enabling Source Clear #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyroach-optimizely
added a commit
that referenced
this pull request
Jun 8, 2018
This reverts commit 390856e.
Merged
kellyroach-optimizely
added a commit
that referenced
this pull request
Jun 8, 2018
kellyroach-optimizely
added a commit
that referenced
this pull request
Jun 26, 2018
* revert get enabled features sorted (#229) * coveralls code coverage (#221) * coveralls added * enable code coverage * add style guide (#233) * data file CDN url changed (#234) * example to show folio3 how to refactor code (#238) * example to show folio3 how to refactor code * write failing test * fix single quote test * get record id to attach with event to remove * fix for TVOS events removal * Remedying Xcode 9.2 compiler warnings in unit tests (#244) * use new notification listeners (#243) * use new notification listeners * fix TVOS errors and rename notification listener methods that were incorrect * Kroach/oasis 2519 release20 master (#246) * Release iOS 2.0.0-beta1 (#230) * Bump version number to 2.2.0-beta1 * Remove unused Beta and RC XCBuildConfiguration's * Update workspace *.xcscheme's and *.pbxproj to Xcode 9.2 recommended settings * Remove static library 'Pods...' from tvOS demo app's Embedded Binaries * CURRENT_PROJECT_VERSION's can't have version suffixes like '-beta1' * Additional OptimizelyTVOSDemoApp images required for App Store 'Validation...' * unexported_symbols.txt update * Update release.sh * Rebuild universal frameworks * CHANGELOG.md update * Major release.sh overhaul. + Conflate all _VERSION's to single OPTIMIZELY_SDK_VERSION . * Improved release.sh * Resolve conflicts between '2.0.x' and 'master' * Release 2.0.0 GA (#245) * Bump version number to 2.0.0 * 'Optimizely Bucketing ID' --> '' per reference java-sdk and design doc * Update CHANGELOG.md * Add 'Bug Fixes' to CHANGELOG.md * unexported_symbols.txt update * Rebuild universal frameworks * Add 1.5.1 message to CHANGELOG.md * Merge 2.0.0 GA changes from 2.0.x into master branch. Summary: Pull request 2.0.0 GA changes made to 2.0.x branch into the master branch. This amounts to cherry-picking commits from 2.0.x and resolving conflicts. Test Plan: * sh ./Scripts/build_all.sh PASSED * 4 Analyze PASSED * 8+1 iOS test suites PASSED * 7+1 tvOS test suites PASSED We seemed to have some issues with tvos test suites last week, but they PASSED 3x in a row today. Reviewers: mike.ng, thomas.zurkan JIRA Issues: OASIS-2519 Differential Revision: https://phabricator.optimizely.com/D19752 * Resolve conflicts (generated-frameworks) (#248) * fix to send new events to new endpoint and any old events that might … (#249) * fix to send new events to new endpoint and any old events that might be around to the old events endpoints * use clientEngine instead of client_engine * add a couple of tests for sending to new and old endpoints * Kroach/oasis 2768 upgradev2 (#251) * Forcing old datafile to include anonymizeIP required by V4 format. * Add testOlderV2Datafile unit test * Pre-Release 2.0.2-beta1 (#252) (#253) * fix to send new events to new endpoint and any old events that might … (#249) * fix to send new events to new endpoint and any old events that might be around to the old events endpoints * use clientEngine instead of client_engine * add a couple of tests for sending to new and old endpoints * Kroach/oasis 2768 upgradev2 (#251) * Forcing old datafile to include anonymizeIP required by V4 format. * Add testOlderV2Datafile unit test * Bump version number to 2.0.2-beta1 * Rebuild universal frameworks * Update CHANGELOG.md * Enabling Source Clear (#255) * Kroach/oasis 2442 xcode94 (#254) * Update Project Settings to Xcode 9.4 recommended settings * Add ', strong, nonnull' to anonymizeIP @Property * Accept Xcode 9.4's recommended Fix's which add 'self->' * Eliminate Xcode Aanalyze warning for line in OPTLYFMDBDatabase.m * Add weakSelf and strongSelf to setupNetworkTimer: * setupNetworkTimer: nit * Kroach/oasis 2442 swift (#256) * Update OptimizelyiOSDemoApp to Swift 4 * 'pod update' and Localytics version update * Localytics version update * Revert "Enabling Source Clear (#255)" This reverts commit 390856e. * Xcode 9.4 recommended upgrade to Pods project settings * Kroach/oasis 2978 variables (#257) * Revive Live Variables API's * Add 2 V3.json datafiles * Repair all broken tests. Make OptimizelyV3Test live variables tests pass. * Add Live Variables (DEPRECATED) code comments * Add 2 'Mobile 1.x Live Variables are DEPRECATED' block comments * Add OPTLYLoggerMessagesLiveVariablesDeprecated log message to deprecated API's * Add #pragms's to get deprecated warnings to emit in old code using Mobile 1.x Variables * Managment -> Management * OPTLYDatafileKeysVariationVariableUsageInstances --> OPTLYDatafileKeysVariationVariables * re-enabled srcclr on every build (#263) * Added SourceClear to run in one build per commit (#258) * added sourceclear to only run in one build per commit * moved sourceclear.sh into Scripts folder * fix typo * it -> is, 'skipping sourceclear' * Add Release 1.5.2 message to master CHANGELOG.md (#267) * Fix impression sent from feature experiment variation toggled off. (#270) * Add environments support to SDK with SDK key initialization (#264) * iOS Environment refactor to use OPTLYDatafileConfig Test Plan: all tests pass on iOS and tvOS. Reviewers: ali, kelly.roach, thomas.zurkan Differential Revision: https://phabricator.optimizely.com/D19924 * Add unit test for initializing with SDK and fix a typo. * Undo disabling of MxP. * projectConfigURLPath: declaration removed * Improve initWithProjectId:withSDKKey: * Use BOOL values YES/NO * Add parentheses and formatting to improve code readability * Add areNilOrEqual:y: and refactor isEqual: for code clarity * Improved OPTLYDatafileConfig.m hash method * NSString+OPTLYCategory.m+.h dropped in favor of adding static method to OPTLYManagerBase.m+.h * Refer to 6 identical strings by SSOT OPTLY_DATAFILE_URL global * Changed enum type SqliteValueType to OPTLYSqliteValueType (#271) * changed enum type SqliteValueType to OPTLYSqliteValueType * Copyright headers updated * Suppress deprecated warnings in OptimizelyV3Test * Correct downloadDatafile:completionHandler: signature in OPTLYDatafileManagerTest.m * Suppress -Wnonnull warnings in tests for illegitmate args * Two nil --> [NSData data] in OPTLYDatafileManagerTest.m * 3x (NSObject *) casts in OPTLYDecisionServiceTest.m * OPTLYUserProfile --> NSDictionary in 2 places in OPTLYDecisionServiceTest.m * Bump version number to 2.0.2-beta2 * Update CHANGELOG.md and 2 code comments in OPTLYManagerBase.h * Improved unexported_symbols.sh * unexported_symbols.sh comment * Rebuild universal frameworks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.