Skip to content

refactor(Live Variables): Removed deprecated functionality for live variables. #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2019
Merged

refactor(Live Variables): Removed deprecated functionality for live variables. #373

merged 2 commits into from
Feb 11, 2019

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • Removed (Deprecated) live variables classes 'OPTLYVariationVariable' and 'OPTLYVariable'.
  • Removed (Deprecated) live variables JSON Mapping, Error Logs, and Messages.
  • Removed (Deprecated) live variables functionality from Project config and SDK classes.
  • Removed (Deprecated) live variables Unit tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 98.117% when pulling b3c1d48 on yasir/remove-live-variables into a9b78c1 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 98.117% when pulling b3c1d48 on yasir/remove-live-variables into a9b78c1 on master.

@coveralls
Copy link

coveralls commented Feb 7, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 98.13% when pulling 51d9c11 on yasir/remove-live-variables into 965d0b8 on master.

@msohailhussain msohailhussain reopened this Feb 8, 2019
@mikeproeng37 mikeproeng37 reopened this Feb 9, 2019
thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 20e8ded into master Feb 11, 2019
@nchilada nchilada deleted the yasir/remove-live-variables branch February 11, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yasirfolio3 @coveralls @thomaszurkan-optimizely @mikeproeng37 @msohailhussain