[GR-67262] Fix JFR GC events. #11570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
checkstyle fix small bug
roberttoyonaga
force-pushed
the
fix-jfr-gc-event
branch
from
cf4c3b2 to
448c06b
Compare
roberttoyonaga
force-pushed
the
fix-jfr-gc-event
branch
3 times, most recently
from
e579446 to
448c06b
Compare
|
Thanks, will be integrated in the next few days. |
christianhaeubl
approved these changes
Jul 8, 2025
| @@ -0,0 +1,69 @@ | |||
| /* | |||
| * Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights reserved. | |||
| * Copyright (c) 2022, 2022, Red Hat Inc. All rights reserved. | |||
There was a problem hiding this comment.
I will change the copyright years of this file to 2025 if this is fine with you.
There was a problem hiding this comment.
Yes please! I forgot to update that. Thanks
|
@christianhaeubl should I now open a backport PR to the GraalVM for JDK25 release branch? |
|
Not necessary, I already did that (but may take a few days until it gets merged and therefore mirrored to GitHub). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently writing JFR
jdk.GarbageCollectionevents incorrectly. The event format has an "event thread" data field, but we are not writing it. This causes the subsequent fields to have incorrect placement and be written wrong as well.Before the fix: notice many fields are blank or zero
After the fix:
I've added a test to catch such issues in the future.
This bug affects the GraalVM for JDK 25 release branch (https://github.com/oracle/graal/tree/release/graal-vm/25.0) as well and should be backported to it.