Feature/uctags2 #2983
Merged
Feature/uctags2 #2983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CtagsTest.bug19195() was newly failing from explicit registration of .S files for the Ctags C parser versus former implicit use of the Ctags Asm parser. With this change, OpenGrok now explicitly registers the Asm parser for .S and .ASM files.
vladak
reviewed
Nov 29, 2019
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/AnalyzerGuru.java
Show resolved
Hide resolved
|
Nice ! Paves the way for #930 I guess. |
|
Thank you for reviewing, @vladak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider for integration this patch as a follow-on to #2979, incorporating feedback from @vladak.
The file extension mapping redundancy in
Ctagsis fixed, and mappings are done based on analyzer prefixes or suffixes duringregisterAnalyzer(). This created a test error for an assembly language test file,bug19195/test.s, which was formerly analyzed by theCAnalyzerbut implicitly tagged by the Ctags Asm parser. I clonedCAnalyzerasAsmAnalyzer, mapping.Sand.ASMto it.Thank you.