Prevent XMLDecoder from loading other than whitelisted classes #3526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The #2329 will be the final fix (YAML or some custom format). |
vladak
reviewed
Apr 7, 2021
opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/ConfigurationClassLoader.java
Show resolved
Hide resolved
vladak
reviewed
Apr 7, 2021
| @Test | ||
| void testLoadingValidConfiguration() throws IOException { | ||
| try (var br = new BufferedReader(new InputStreamReader(ConfigurationTest.class.getClassLoader() | ||
| .getResourceAsStream("configuration/valid_configuration.xml")))) { |
There was a problem hiding this comment.
would be more robust to encode a Configuration instance and store it in the file however let's leave it like it is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this as a draft because this fix is only a workaround. I'm not really sure I whitelisted all the possible classes and I do not know how to achieve this more nicely. I think we can use this as an interim solution until we get the yaml config working.
Thanks to Bobby Rauch (Accenture) for reporting the issue.