Skip to content

Docker tools timeout redux #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Conversation

vladak
Copy link
Member

@vladak vladak commented Mar 29, 2023

#4247 (reply in thread) inspired me to allow command argument substitution to use environment variables as values.

While making the change, I realized that the command structure is broken - it needs to be a dictionary for stuff like resource limits and argument substitution to work. The per project workflow wiki will have to be adapted.

Command configuration in YAML now looks like this:

- command:
    args: [cmd, "--foo", "%FOO%"]
    limits: {RLIMIT_NOFILE: 1024}
    args_subst: {"%FOO%": "$FOO"}

The $ prefix in the $FOO value means that it will not be taken as literal; instead, the value of environment variable FOO will be taken.

@vladak vladak added tools Python tools docker labels Mar 29, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 29, 2023
@vladak vladak merged commit 8f77a81 into oracle:master Mar 29, 2023
@vladak vladak deleted the docker_tools_timeout_redux branch March 29, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker OCA Verified All contributors have signed the Oracle Contributor Agreement. tools Python tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant