convert LDAP authorization plugin configuration to YAML #4599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little brother of #2329, just for the LDAP authorization plugins. I have chosen YAML.
I had to select the members by hand via tha
@JsonProperty
, otherwise this leads to stack overflow via infinite recursion by callingLdapServer#isWorking()
from the Jackson serialization methods.The integer fields not present in the configuration are deserialized to zero values,
opengrok/plugins/src/main/java/opengrok/auth/plugin/ldap/LdapServer.java
Lines 261 to 266 in 953e10a
This will also help with the stability of the tests, as I have seen
plugins/src/test/java/opengrok/auth/plugin/configuration/ConfigurationTest.java
fail in the same way as the indexer configuration (#4441).