[GR-45043] Integrate YARP parser [Part 8] #3406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
ak/adopt-yarp-parser-part-8
branch
6 times, most recently
from
e4a357c to
39cb22d
Compare
graalvmbot
force-pushed
the
ak/adopt-yarp-parser-part-8
branch
3 times, most recently
from
e05a5a1 to
92a7319
Compare
…ception in runtime
…iables within a block) immediately
* Before Prism it worked thanks to __FILE__ returning the real path instead of `<internal:core> core/struct.rb` which is more correct.
* This avoids:
Invalid source section bounds. (java.lang.IllegalArgumentException)
from com.oracle.truffle.api.source.Source.assertValid(Source.java:735)
from com.oracle.truffle.api.source.Source.createSection(Source.java:669)
* We need to remove the eager check using toJavaStringOrThrow() because
e.g. spec/ruby/language/regexp/encoding_spec.rb fails it.
.toJavaStringUncached() will anyway not fail but use � in that case.
…ic for pre-initialization * Notably the absolute path of did_you_mean.rb, etc would get in the image and fail the check.
* Those were not noticed before because of `--experimental-options --pattern-matching` always passed for specs.
* And also some string/encoding-related missing SyntaxError from Prism.
* And exclude on missing SyntaxError.
…tants, attribute and reference optional assignment
…at represents encoding either forced or specified with flag
* This avoids creating the TextMap early and is likely faster.
…e it in YARPTranslator * Remove corresponding excludes for MRI tests which now pass.
graalvmbot
force-pushed
the
ak/adopt-yarp-parser-part-8
branch
from
49f1ef1 to
e31efe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.