Skip to content

Accepts JSON without key [Issue #1576] #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Accepts JSON without key [Issue #1576] #2219

wants to merge 1 commit into from

Conversation

marcstern
Copy link

This accepts a valid JSON request with only a number or a string, nothing else.
Example:
--29000000-B--
POST /test/json/test.html HTTP/1.1
content-type: application/json
Host: test
Content-Length: 2
User-Agent: Mozilla 4.0
Accept: text/html, image/gif, image/jpeg, *; q=.2, /; q=.2

--29000000-C--
25
--29000000-F--

@zimmerle zimmerle added the 2.x Related to ModSecurity version 2.x label Dec 13, 2019
@marcstern
Copy link
Author

Anything I can do to have this reviewed/accepted?

@zimmerle
Copy link
Contributor

Sorry for the delay.

That is in the review queue. Other users who fill interest to have this feature could participate on the discussion here. The attention from the community to a certain feature is taken into consideration to prioritize the merge.

Up Front, I can tell that I am missing test cases for this feature. Not mandatory at this point, but, it will help a lot during the review process.

@marcstern
Copy link
Author

I cannot find a test for the JSOn parser, as there's for the multipart parser for instance. If there's one, I can add this test case.

@marcstern
Copy link
Author

I created a new PR with a test: #2363
I hope it'll be accepted now.

@marcstern marcstern closed this Jul 17, 2020
@marcstern marcstern deleted the v2/json_no_key branch August 11, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants