Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oxidecomputer/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6eeab203
Choose a base ref
...
head repository: oxidecomputer/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9ef82bad
Choose a head ref
  • 12 commits
  • 60 files changed
  • 6 contributors

Commits on Oct 30, 2024

  1. Fix rendering of empty IP pool description (#2528)

    fix rendering of empty IP pool description
    david-crespo authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ca7f6e2 View commit details
    Browse the repository at this point in the history
  2. chore: bump actions to node 22 because it's LTS now (#2527)

    bump actions to node 22 because it's LTS now
    david-crespo authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0552b62 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Tell password managers to stop trying to fill name field (#2530)

    tell password managers to stop trying to fill name field
    david-crespo authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b4920b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    b01ca85 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Reorder IDP form elements (#2511)

    * Reorder IDP create form elements
    
    * Update edit form order
    
    * Add docs link for Identity Providers
    
    * Remove checkbox for Signed Requests
    
    * Add side modal heading (#2533)
    
    * Add side modal heading
    
    * Remove commented input legend
    
    * very important mt-2
    
    * cut one word to cut a whole line out of the targets info box
    
    ---------
    
    Co-authored-by: David Crespo <[email protected]>
    
    * change form section headings to SideModal.Heading, remove "General"
    
    ---------
    
    Co-authored-by: Benjamin Leonard <[email protected]>
    Co-authored-by: David Crespo <[email protected]>
    3 people authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7dcd41c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Virtual list entry for arbitrary values in comboboxes (#2518)

    * Update how allowArbitraryValue functions in comboboxes
    
    * Update vertical position, to reduce peek-through of button on lower layer
    
    * update test to work with new approach
    
    * Update tests, though Safari is still a bit touchy
    
    * Select via Enter
    
    * Update test
    
    * Change UX for allowArbitraryOption
    
    * Update test
    
    * More test updating
    
    * new copy: 'Use custom value:'
    
    * gray out "custom:" in virtual item, fix query clearing onClose, e2e test
    
    * use key to nuke combobox on host filter value type change
    
    * explicit useEffect for clearing query whenever value is cleared
    
    ---------
    
    Co-authored-by: David Crespo <[email protected]>
    charliepark and david-crespo authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6f83d41 View commit details
    Browse the repository at this point in the history
  2. chore: Bump playwright and MSW to see if it affects safari flakes (#2538

    )
    
    bump playwright and msw to see if it affects safari flakes
    david-crespo authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dcddc81 View commit details
    Browse the repository at this point in the history
  3. Fix radix warnings on side modal (#2536)

    fix radix warnings on side modal
    david-crespo authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5edf89e View commit details
    Browse the repository at this point in the history
  4. Require loading prop on SideModalForm, fix snapshot create (#2539)

    require loading prop on side modal form, fix snapshot create
    david-crespo authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8da7b6d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Automatic ACS URL in IdP forms w/ copy button (#2510)

    * Add copyable prop to input; set up automatic ACS URL
    
    * unnecessary comment
    
    * Add tooltip when value is too long to see
    
    * No need for useEffect
    
    * Revert to useEffect; add tests for getSubdomain
    
    * Update design of copyable input
    
    * Remove right padding for copyable text
    
    * full-height button
    
    * slightly wider
    
    * Combobox border tweaks
    
    * slightly taller Listbox to match other inputs
    
    * shuffle files around, make helper not depend on window
    
    * constrain TextInput value to be a string
    
    * test IdP create and edit
    
    * Add checkbox to allow user to use custom ACS URL
    
    * Update test to handle unchecking/rechecking standard ACS URL
    
    * Update microcopy
    
    * use regular useState instead of form for the checkbox
    
    ---------
    
    Co-authored-by: David Crespo <[email protected]>
    charliepark and david-crespo authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    48693a2 View commit details
    Browse the repository at this point in the history
  2. Add help text + request signing section header to IdP form (#2537)

    * Add request signing section header to IdP form
    
    * help text in the identity provider form? in this economy?
    
    * review feedback, test login path preview
    david-crespo authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    23beefe View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Bring back topbar breadcrumbs (#2529)

    * Most of the work to get breadcrumbs in place of top bar pickers
    
    * Bot commit: format with prettier
    
    * Refactor; add System page breadcrumbs
    
    * proper arrow; spacing tweaks
    
    * Tighten top bar by a few pixels
    
    * No back arrow on root pages; no white link when only one item on page
    
    * Update tests
    
    * Style tweaks
    
    * Fix current selected item icon alignment
    
    * Cleanup
    
    * Breadcrumbs powered by `useMatches()` (#2531)
    
    * first pass at matches-based breadcrumbs. route config changes required
    
    * kinda fix things in the route config
    
    * use-title.ts -> use-crumbs.ts
    
    * Update import
    
    ---------
    
    Co-authored-by: Charlie Park <[email protected]>
    
    * Update expected strings in e2e tests
    
    * Fix multiple locator match issue, though we might change text on button
    
    * use main to select connect button instead of connect breadcrumb
    
    * slight refactor on system/silos crumb
    
    * move Breadcrumbs into TopBar
    
    * prop name systemOrSilo
    
    * adjust main pane / footer height on serial console
    
    * add titleOnly concept for form crumbs, apply to all routes
    
    * --top-bar-height CSS var
    
    * fix ssh keys and floating IP edit crumbs
    
    * fix z-index on modal dialog overlay so it covers topbar
    
    * Bot commit: format with prettier
    
    * fix crumbs of pageless route nodes, very zany snapshot test for the crumbs
    
    * use helpers to make everything a little cleaner
    
    * write a test, find a bug!
    
    funny how that works
    
    ---------
    
    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: Benjamin Leonard <[email protected]>
    Co-authored-by: David Crespo <[email protected]>
    Co-authored-by: David Crespo <[email protected]>
    5 people authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    9ef82ba View commit details
    Browse the repository at this point in the history
Loading