Add help text + request signing section header to IdP form #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
request-signing-section
branch
from
046ce00 to
4b51f56
Compare
david-crespo
force-pushed
the
request-signing-section
branch
from
4b51f56 to
16fbb44
Compare
|
Moved on top of #2510 so we can get extra snazzy. 
|
david-crespo
changed the title
charliepark
reviewed
Nov 8, 2024
app/forms/idp/create.tsx
Outdated
| <code> | ||
| /login/{silo}/saml/{name.trim() || 'idp-name'} | ||
| </code> | ||
| . |
There was a problem hiding this comment.
If we're ending the copy with <code>, I think it looks better (and clearer) without the ultimate period. Thoughts about leaving that off?
There was a problem hiding this comment.
I have it in there because it’s two sentences. Otherwise I would leave it out.
There was a problem hiding this comment.
Hm, yeah I think you’re right. I’ll take it out.
david-crespo
force-pushed
the
request-signing-section
branch
from
16fbb44 to
a877efe
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 10, 2024
oxidecomputer/console@6eeab20...9ef82ba * [9ef82bad](oxidecomputer/console@9ef82bad) oxidecomputer/console#2529 * [23beefea](oxidecomputer/console@23beefea) oxidecomputer/console#2537 * [48693a22](oxidecomputer/console@48693a22) oxidecomputer/console#2510 * [8da7b6d0](oxidecomputer/console@8da7b6d0) oxidecomputer/console#2539 * [5edf89ef](oxidecomputer/console@5edf89ef) oxidecomputer/console#2536 * [dcddc81f](oxidecomputer/console@dcddc81f) oxidecomputer/console#2538 * [6f83d416](oxidecomputer/console@6f83d416) oxidecomputer/console#2518 * [7dcd41c2](oxidecomputer/console@7dcd41c2) oxidecomputer/console#2511 * [b01ca85d](oxidecomputer/console@b01ca85d) bump omicron to latest main * [b4920b11](oxidecomputer/console@b4920b11) oxidecomputer/console#2530 * [0552b62e](oxidecomputer/console@0552b62e) oxidecomputer/console#2527 * [ca7f6e20](oxidecomputer/console@ca7f6e20) oxidecomputer/console#2528
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 10, 2024
oxidecomputer/console@6eeab20...9ef82ba * [9ef82bad](oxidecomputer/console@9ef82bad) oxidecomputer/console#2529 * [23beefea](oxidecomputer/console@23beefea) oxidecomputer/console#2537 * [48693a22](oxidecomputer/console@48693a22) oxidecomputer/console#2510 * [8da7b6d0](oxidecomputer/console@8da7b6d0) oxidecomputer/console#2539 * [5edf89ef](oxidecomputer/console@5edf89ef) oxidecomputer/console#2536 * [dcddc81f](oxidecomputer/console@dcddc81f) oxidecomputer/console#2538 * [6f83d416](oxidecomputer/console@6f83d416) oxidecomputer/console#2518 * [7dcd41c2](oxidecomputer/console@7dcd41c2) oxidecomputer/console#2511 * [b01ca85d](oxidecomputer/console@b01ca85d) bump omicron to latest main * [b4920b11](oxidecomputer/console@b4920b11) oxidecomputer/console#2530 * [0552b62e](oxidecomputer/console@0552b62e) oxidecomputer/console#2527 * [ca7f6e20](oxidecomputer/console@ca7f6e20) oxidecomputer/console#2528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2511 (comment). Let's be sooooooo helpful.