Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oxidecomputer/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a228b75b
Choose a base ref
...
head repository: oxidecomputer/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 69ba87b7
Choose a head ref
  • 8 commits
  • 61 files changed
  • 3 contributors

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    a18c7a8 View commit details
    Browse the repository at this point in the history
  2. Turn on type-aware lint rules (#2259)

    * turn on a couple of type-aware lint rules
    
    * turn on recommended-type-checked except for all the ones I hate
    
    * hm we actually sort of caught a bug and I'm not sure why eslint made this possible
    david-crespo authored May 24, 2024
    Configuration menu
    Copy the full SHA
    bf97ebc View commit details
    Browse the repository at this point in the history
  3. Turn on react/button-has-type lint rule and fix all (#2261)

    * turn on react/button-has-type lint rule and fix all
    
    * add MiniTable.RemoveCell to reduce fiddly logic
    david-crespo authored May 24, 2024
    Configuration menu
    Copy the full SHA
    9b7ea53 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Add floating ips to instance create (#2252)

    * Add step to attach floating IPs to instance creation form
    
    * Slight refactoring of const names
    
    * Smoother handling of unchecking Floating IP box
    
    * Add noItemsPlaceholder to Listbox
    
    * add type guard to clean up code
    
    * Remove checkbox; button-only to open modal
    
    * only show message when IPs are available to attach
    
    * Simplify floating IP label, sans-pool
    
    * revert removal of api call
    
    * Add header to new file
    
    * Merge main; disable modal trigger button if no floating IPs available
    
    * Add empty state for when no floatingIPs exist
    
    * Update app/forms/instance-create.tsx
    
    Co-authored-by: David Crespo <[email protected]>
    
    * Refactor deeply-nested JSX
    
    * Extract FloatingIpLabel, update TipIcon copy
    
    * Extract Listbox labels
    
    * Revert "Extract Listbox labels"
    
    This reverts commit 59b27d1.
    
    * Refactor to use useState instead of weird form entry for state management
    
    * small refactor on onAction
    
    * another small refactor
    
    * refactor to use FloatingIp in useState, rather than a string
    
    * simplify and future-proof logic
    
    Co-authored-by: David Crespo <[email protected]>
    
    * Add test for attaching a floating IP to instance
    
    * include assertion regarding IP address in modal message
    
    * Add test for empty floating IPs state
    
    * Update mock serviceworker to attach IPs to instance; update tests
    
    * Move ipFromPool to util function
    
    * refactor
    
    * fix the button!
    
    * use RemoveCell in floating IPs MiniTable
    
    * Add test to remove row from form
    
    ---------
    
    Co-authored-by: David Crespo <[email protected]>
    Co-authored-by: David Crespo <[email protected]>
    3 people authored May 25, 2024
    Configuration menu
    Copy the full SHA
    c9f2bba View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    ab2939b View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Use Remeda (lodash-like lib) (#2269)

    * replace implementations of array utils with remeda calls to prove identical
    
    * get rid of mapValues, lowestBy, sumBy, isTruthy (going away in TS 5.5 anyway)
    
    * get rid of pick
    
    * get rid of sortBy and splitOnceBy
    david-crespo authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    13ce748 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Upgrade xterm, fix super-wide serial console page (#2272)

    upgrade xterm packages to new @xterm namespace version
    david-crespo authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    13d46e8 View commit details
    Browse the repository at this point in the history
  2. Handle serial console close event properly (#2246)

    * the event is 'close', not 'closed'
    
    * plumb instance state into serial console skeleton
    
    * make a dent in a more robust can't connect message
    
    * handle error case in mediocre fashion, aria-label on scroll buttons
    david-crespo authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    69ba87b View commit details
    Browse the repository at this point in the history
Loading