Turn on type-aware lint rules

[david-crespo]

I got nerd sniped by this tweet and first turned on the full recommended config (which I've tried before) and it was awful:

Then I read this great blog post, which is linked in the tweet

https://www.joshuakgoldberg.com/blog/rust-based-javascript-linters-fast-but-no-typed-linting-right-now/#recap-type-checked-linting

and it points to a couple of specific rules that it likes. So I tried turning those on and it is actually a little bit useful and doesn't slow things down that much (I also narrowed down the scope of what we're linting a bit).

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	May 24, 2024 4:50pm

[david-crespo]

This is interesting! What happened here is that the new eslint rule made me remove the async because there was no await, which allowed TS to see that the function was not returning a promise like it was supposed to (I guess every async function returns Promise<_> automatically), so that errored, alerting me to the fact that this is set up wrong. It was working fine because of the manual toast, but the errorTitle bit below now covers that because the error handled inside confirmAction.

This is kind of a confusing pattern, but I think the idea was to ensure that there is always some error toast. On unconfirmed actions like instance start, there's nothing forcing you to handle the error, so if you forget to define onError, it does nothing on error, which is annoying. The problem now is that on ones wrapped in confirmAction, you don't see an onError, so maybe you think that's the normal way, but for non-confirmed actions you need to define it.