Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oxidecomputer/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f52f50c
Choose a base ref
...
head repository: oxidecomputer/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3e5a0a1
Choose a head ref
  • 5 commits
  • 30 files changed
  • 5 contributors

Commits on Apr 3, 2025

  1. Configuration menu
    Copy the full SHA
    30b1afd View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2025

  1. Fix metric loading and empty states (#2779)

    * scenarios for mock oxql data
    
    * explicit loading state for timeserieschart
    
    * test it, switch back to project timeseries endpoint
    
    * also test group by error workaround
    david-crespo authored Apr 4, 2025
    Configuration menu
    Copy the full SHA
    e1d8077 View commit details
    Browse the repository at this point in the history
  2. build(deps-dev): bump vite from 6.2.4 to 6.2.5 (#2782)

    Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.2.4 to 6.2.5.
    - [Release notes](https://github.com/vitejs/vite/releases)
    - [Changelog](https://github.com/vitejs/vite/blob/v6.2.5/packages/vite/CHANGELOG.md)
    - [Commits](https://github.com/vitejs/vite/commits/v6.2.5/packages/vite)
    
    ---
    updated-dependencies:
    - dependency-name: vite
      dependency-version: 6.2.5
      dependency-type: direct:development
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Apr 4, 2025
    Configuration menu
    Copy the full SHA
    ae7a989 View commit details
    Browse the repository at this point in the history
  3. Move error into picker (#2780)

    * Move error into picker
    
    * Use flex avoid negative margin
    
    * Fix border hover
    
    * Fix missing border and today dot error colour
    benjaminleonard authored Apr 4, 2025
    Configuration menu
    Copy the full SHA
    ab06a33 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2025

  1. Add create and edit functionality to anti-affinity groups (#2775)

    * Enable removal of group member
    
    * Enable deletion of group
    
    * move away from useMemo for columns
    
    * Update copy in remove confirm modal
    
    * Update copy in delete modal
    
    * use apiq since we're not paginating
    
    * use the id for delete
    
    * merged main and reconciling diffs
    
    * Add new anti-affinity group
    
    * ah … crumbs
    
    * Edit anti-affinity group is working
    
    * Fix bug; add ID column to table
    
    * can add instances to an anti-affinity group
    
    * Update to ID column truncation
    
    * Refactoring
    
    * Missed a spot in the refactoring
    
    * Update snapshots
    
    * Can just use prefetchQuery, since we don't need returned data yet
    
    * reorder functions
    
    * move instanceList fetching up a level; use to disable button when no instances available
    
    * Use existing types for forms
    
    * export function as default
    
    * refactor idCell
    
    * Update mock-api/msw/handlers.ts
    
    Co-authored-by: David Crespo <[email protected]>
    
    * don't reuse AffinityPageHeader
    
    * Shorter button copy; new page header
    
    * Don't include sorting; already present in actual data
    
    * Try 'anti-affinity' as header / nav link
    
    * Clean up copy button a bit
    
    * More clever disabledReason; needs max member verification
    
    * use regular link for group edit row action
    
    * put it back to Affinity title
    
    * draft docs popover
    
    * A few more refactors / PR comments
    
    * routing fix
    
    * reintroduce convert in routes for group create
    
    * update max members value
    
    * Link to specific commit for line reference stability
    
    * Add e2e tests
    
    * Refresh of Affinity Groups table columns; use count in place of instance names
    
    * update test
    
    * don't fetch affinity groups
    
    * members col -> instances, don't validate name uniqueness
    
    * add delete and docs popover to group detail, use confirmDelete
    
    * help text on policy field and tip icon on policy columns
    
    * merge main and resolve conflicts with AffinityGroupPolicyBadge
    
    * put back the line about policy in the popover
    
    * remove title from icons in sidebar nav
    
    * Refactoring form in add instance to A-A group modal
    
    * type -> group type, remove description column
    
    * on second thought: make page title Affinity Groups
    
    * simplify form reset by unmounting, test that in e2e
    
    * use handleSubmit higher so we don't have to type explicitly
    
    * make enter submit add instance modal form
    
    * link to instance settings rather than default tab
    
    * hopefully final policy help copy tweaks
    
    ---------
    
    Co-authored-by: David Crespo <[email protected]>
    Co-authored-by: David Crespo <[email protected]>
    3 people authored Apr 8, 2025
    Configuration menu
    Copy the full SHA
    3e5a0a1 View commit details
    Browse the repository at this point in the history
Loading