Expand rack into properties table, add extra table columns #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zephraph
commented
Feb 1, 2023
zephraph
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Lots to follow up on here, but we'll get to it. |
david-crespo
reviewed
Feb 1, 2023
| <Column id="slot" accessor={(_, index) => index} header="slot" /> | ||
| <Column id="sled" accessor={() => `SLD0`} header="sled" /> | ||
| <Column id="location" accessor={(_, index) => `N${index}`} header="location" /> | ||
| <Column id="status" accessor={() => 'active'} header="status" cell={LabelCell} /> |
There was a problem hiding this comment.
dang, what are these function accessors?
There was a problem hiding this comment.
Mostly just placeholders for now.
There was a problem hiding this comment.
Oh, I didn't get it — if you give it a function, the return value is the value for the column. I thought the functions were somehow producing an accessor key, which in hindsight makes no sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.