Firewall rule improvements #1887

benjaminleonard · 2024-01-15T18:14:16Z

Closes #1571
Closes #1915

Makes name clickable (takes you to the edit form)
Add direction column:

Make action title case
Use number field for priority:

Use mini table:

Clear is disabled when associated fields are not dirty

- Make name clickable - Add direction column - Improve action casing

vercel · 2024-01-15T18:14:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	Jan 29, 2024 9:16pm

app/pages/project/networking/VpcPage/tabs/VpcFirewallRulesTab.tsx

libs/util/str.ts

david-crespo · 2024-01-26T21:38:49Z

I think we need to undo the checkbox changes like in #1867

david-crespo · 2024-01-26T21:50:14Z

app/pages/project/networking/VpcPage/tabs/VpcFirewallRulesTab.tsx

+              className="peer absolute inset-0"
+              onClick={() => setEditing(info.row.original)}
+            />
+            <div className="peer-hover:underline">{info.getValue()}</div>


Bad news — this trick isn't working for me in Firefox. The button has zero width.

Can probably replace it with the same trick we're using on the clickability PR

I can create a buttonCell component, but really I think the best solution here would to change it to route tabs, reuse linkCell, and allow the edit modal to be linkable.

Will redo this in a followup.

david-crespo · 2024-01-29T16:59:43Z

app/pages/project/networking/VpcPage/VpcPage.tsx

+    apiQueryClient.prefetchQuery('vpcSubnetList', {
+      query: { project, vpc, limit: 25 },
+    }),
+  ])


this makes the tabs load instantly, been meaning to fix this

david-crespo · 2024-01-29T17:00:57Z

libs/util/str.spec.ts

+  // lol this title doesn't match the assert
+  it('retains existing capitalization of non-initial letters', () => {
+    expect(titleCase('hElLo wOrLd')).toBe('Hello World')
+  })


delete this or fix the test description. should be "does not retain"

david-crespo · 2024-01-29T17:02:16Z

libs/ui/lib/checkbox/Checkbox.tsx

        {...inputProps}
      />
-      {inputProps.checked && !indeterminate && <Check />}
+      {!indeterminate && <Check />}


Not sure any of the changes in this file are needed anymore after d14332c. This line in particular seems dubious.

This reverts commit 16deaac.

david-crespo · 2024-01-29T19:27:11Z

On second thought, the route tabs thing is invasive enough that I want to do it in a second PR.

david-crespo · 2024-01-29T21:01:59Z

app/forms/firewall-rules-create.tsx

+                        targets.value.filter(
+                          (i) => !(i.value === t.value && i.type === t.type)
+                        )
+                      )


this is a bug you introduced. wait for it...

david-crespo · 2024-01-29T21:03:27Z

app/forms/firewall-rules-create.tsx

                type &&
                value &&
-                !hosts.value.some((t) => t.value === value || t.type === type)
+                !hosts.value.some((t) => t.value === value && t.type === type)


this is a very similar bug that has been there since Oct 2022 (it was me), preventing anyone from adding two host filters with the same value or the same type (or both, which is what we actually want)

I learned from the best

benjaminleonard added 2 commits January 15, 2024 17:45

Table improvements

8c48bf4

- Make name clickable - Add direction column - Improve action casing

Firewall rule form improvements

211b9a2

david-crespo reviewed Jan 15, 2024

View reviewed changes

app/pages/project/networking/VpcPage/tabs/VpcFirewallRulesTab.tsx Outdated Show resolved Hide resolved

david-crespo reviewed Jan 15, 2024

View reviewed changes

libs/util/str.ts Show resolved Hide resolved

benjaminleonard added 2 commits January 16, 2024 09:18

Use same labels as API

c13cfec

Test titleCase

2984d45

vercel bot deployed to Preview January 16, 2024 09:19 View deployment

benjaminleonard added 2 commits January 16, 2024 09:54

Checkout CheckboxGroup from ssh-key-select

6789fc8

Add CheckboxGroupField

4cd5f69

vercel bot deployed to Preview January 16, 2024 09:55 View deployment

Remove unused prop

bed7982

vercel bot deployed to Preview January 16, 2024 10:02 View deployment

benjaminleonard added 2 commits January 16, 2024 12:02

Disable grouping (commas) on number field

2bbc392

Fix test

8849ed7

vercel bot deployed to Preview January 16, 2024 12:10 View deployment

Actually fix test

71e8e64

vercel bot deployed to Preview January 16, 2024 12:46 View deployment

benjaminleonard marked this pull request as ready for review January 22, 2024 16:42

Merge branch 'main' into firewall-rule-improvements

14dba3b

vercel bot deployed to Preview January 26, 2024 21:42 View deployment

undo checkbox thing

d14332c

vercel bot deployed to Preview January 26, 2024 21:45 View deployment

david-crespo reviewed Jan 26, 2024

View reviewed changes

vercel bot deployed to Preview January 26, 2024 22:00 View deployment

prefetch subnets and firewall rules, sort by priority, better col order

31b884c

david-crespo force-pushed the firewall-rule-improvements branch from cb9ac23 to 31b884c Compare January 26, 2024 22:14

vercel bot deployed to Preview January 26, 2024 22:14 View deployment

david-crespo reviewed Jan 29, 2024

View reviewed changes

Merge branch 'main' into firewall-rule-improvements

2f5b3b1

vercel bot deployed to Preview January 29, 2024 18:45 View deployment

Blocking out routes (incomplete)

16deaac

vercel bot deployed to Preview January 29, 2024 18:47 View deployment

Revert "Blocking out routes (incomplete)"

36ad38f

This reverts commit 16deaac.

vercel bot deployed to Preview January 29, 2024 19:27 View deployment

david-crespo added 3 commits January 29, 2024 13:28

remove redundant/incorrect test from chatgpt

fa9c1e8

undo checkbox changes

fae42ca

postpone clickable name until next PR

694a734

vercel bot deployed to Preview January 29, 2024 19:42 View deployment

epic e2e tests for fiddly hosts and targets tables, fix two bugs!

430f9fa

vercel bot deployed to Preview January 29, 2024 21:01 View deployment

david-crespo reviewed Jan 29, 2024

View reviewed changes

do hosts and targets logic slightly nicer

4e1efe4

david-crespo enabled auto-merge (squash) January 29, 2024 21:15

vercel bot deployed to Preview January 29, 2024 21:16 View deployment

david-crespo mentioned this pull request Jan 29, 2024

Firewall rule issues #1571

Closed

david-crespo merged commit e2d82a4 into main Jan 29, 2024

david-crespo deleted the firewall-rule-improvements branch January 29, 2024 21:23

david-crespo mentioned this pull request Jan 29, 2024

Linkify the firewall rules name cell #1921

Merged

david-crespo mentioned this pull request Jan 31, 2024

Bump web console oxidecomputer/omicron#4946

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Firewall rule improvements #1887

Firewall rule improvements #1887

Uh oh!

benjaminleonard commented Jan 15, 2024 •

edited by david-crespo

Loading

Uh oh!

vercel bot commented Jan 15, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

david-crespo commented Jan 26, 2024

Uh oh!

david-crespo Jan 26, 2024

Uh oh!

benjaminleonard Jan 26, 2024

Uh oh!

benjaminleonard Jan 29, 2024

Uh oh!

david-crespo Jan 29, 2024

Uh oh!

david-crespo Jan 29, 2024

Uh oh!

david-crespo Jan 29, 2024

Uh oh!

david-crespo Jan 29, 2024

Uh oh!

david-crespo commented Jan 29, 2024

Uh oh!

david-crespo Jan 29, 2024

Uh oh!

david-crespo Jan 29, 2024 •

edited

Loading

Uh oh!

benjaminleonard Jan 29, 2024

Uh oh!

Uh oh!

Firewall rule improvements #1887

Firewall rule improvements #1887

Uh oh!

Conversation

benjaminleonard commented Jan 15, 2024 • edited by david-crespo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david-crespo commented Jan 26, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-crespo commented Jan 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-crespo Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

benjaminleonard commented Jan 15, 2024 •

edited by david-crespo

Loading

vercel bot commented Jan 15, 2024 •

edited

Loading

david-crespo Jan 29, 2024 •

edited

Loading