Fix instance delete success callback #2165
Merged
+25
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 18, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2156 revealed an existing bug (not sure why it was working before!) where we try to call both
onSuccessandonDeleteon successful instance delete. Once the bug started happening,onSuccessmeant that we'd try to navigate to instance detail after deleting that instance, which 404s. This fixes it so we only callonDeleteon successful delete, which takes us back to the instance list. I also added a test that would have caught this, and added anonDeleteto instances list which refreshes the list.