Skip to content

Conversation

charliepark
Copy link
Contributor

@charliepark charliepark commented Jun 24, 2024

Fixes #2263

Thanks @FelixMcFelix for the consultation. The host filter message is the main addition, but there are also small tweaks to the other messages.

Screenshot 2024-06-26 at 4 22 52 PM

Screenshot 2024-06-26 at 4 23 01 PM

Screenshot 2024-06-26 at 4 23 05 PM

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Jun 26, 2024 9:23pm

@david-crespo
Copy link
Collaborator

I find the wording a little unsatisfying, let's mull it over

@david-crespo david-crespo changed the title firewall filter copy More firewall rule form help copy Jun 26, 2024
Copy link

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tooltips look great! They feel more concise while highlighting some edge cases, I like them.

@david-crespo david-crespo merged commit dcec501 into main Jun 26, 2024
@david-crespo david-crespo deleted the 2263-firewall-filter-copy branch June 26, 2024 21:44
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Jun 27, 2024
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add help text on firewall rule form explaining what a host filter does
3 participants