Instances table: remove hostname, normal row height, split CPU/RAM #2389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
cc @benjaminleonard with one fewer column, I think this would look better with non-tall rows if we can figure out a way to make CPU and RAM look all right. This isn't bad: 
|
|
Looks good to me |
david-crespo
changed the title
|
It's really surprising to me that changing this extremely key table did not cause any e2e tests to fail, so I'm going to add one. |
david-crespo
force-pushed
the
remove-hostname
branch
from
cb91b6b to
b26187c
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 21, 2024
oxidecomputer/console@33b7a50...8dcddce * [8dcddcef](oxidecomputer/console@8dcddcef) oxidecomputer/console#2392 * [f53bb383](oxidecomputer/console@f53bb383) oxidecomputer/console#2387 * [6a005a0b](oxidecomputer/console@6a005a0b) oxidecomputer/console#2389 * [2f83a1fb](oxidecomputer/console@2f83a1fb) tweak firewall rule copy (closes oxidecomputer/console#2348) * [22bdac78](oxidecomputer/console@22bdac78) oxidecomputer/console#2386 * [5353a6ea](oxidecomputer/console@5353a6ea) oxidecomputer/console#2385 * [7cf1ed54](oxidecomputer/console@7cf1ed54) oxidecomputer/console#2383 * [c52cc37b](oxidecomputer/console@c52cc37b) oxidecomputer/console#2382 * [e442f6bd](oxidecomputer/console@e442f6bd) oxidecomputer/console#2378
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 21, 2024
oxidecomputer/console@33b7a50...8dcddce * [8dcddcef](oxidecomputer/console@8dcddcef) oxidecomputer/console#2392 * [f53bb383](oxidecomputer/console@f53bb383) oxidecomputer/console#2387 * [6a005a0b](oxidecomputer/console@6a005a0b) oxidecomputer/console#2389 * [2f83a1fb](oxidecomputer/console@2f83a1fb) tweak firewall rule copy (closes oxidecomputer/console#2348) * [22bdac78](oxidecomputer/console@22bdac78) oxidecomputer/console#2386 * [5353a6ea](oxidecomputer/console@5353a6ea) oxidecomputer/console#2385 * [7cf1ed54](oxidecomputer/console@7cf1ed54) oxidecomputer/console#2383 * [c52cc37b](oxidecomputer/console@c52cc37b) oxidecomputer/console#2382 * [e442f6bd](oxidecomputer/console@e442f6bd) oxidecomputer/console#2378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2357
We were giving
hostnameway too much prominence considering it's not really doing anything.Before
After