Skip to content

Give extra line in confirm modals its own paragraph #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Give extra line in confirm modals its own paragraph #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions app/pages/project/instances/actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,15 @@ export const useMakeInstanceActions = (
}),
modalTitle: 'Confirm stop instance',
modalContent: (
<p>
Are you sure you want to stop <HL>{instance.name}</HL>? Stopped instances
retain attached disks and IP addresses, but allocated CPU and memory are
freed.
</p>
<div className="space-y-2">
<p>
Are you sure you want to stop <HL>{instance.name}</HL>?
</p>
<p>
Stopped instances retain attached disks and IP addresses, but allocated
CPU and memory are freed.
</p>
</div>
),
errorTitle: `Error stopping ${instance.name}`,
})
Expand Down
7 changes: 4 additions & 3 deletions app/stores/confirm-delete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ export const confirmDelete =
actionConfig: {
doAction: doDelete,
modalContent: (
<p>
Are you sure you want to delete {displayLabel}? {extraContent}
</p>
<div className="space-y-2">
<p>Are you sure you want to delete {displayLabel}?</p>
{extraContent ? <p>{extraContent}</p> : null}
</div>
),
errorTitle: 'Could not delete resource',
modalTitle,
Expand Down
Loading