Instance auto restart #2644

benjaminleonard · 2025-01-09T11:55:05Z

Validate conditional rendering is correct
Automatically set autoRestartEnabled to match actual API behaviour
Add icon to design system
Write docs text
Add settings items help text
Show last auto restarted?

I'm sure someone will talk me down from the slow spinning icon when auto restart is enabled.

vercel · 2025-01-09T11:55:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	Feb 11, 2025 7:06pm

app/components/DocsPopover.tsx

app/pages/project/instances/instance/tabs/SettingsTab.tsx

app/components/InstanceAutoRestartPopover.tsx

hawkw

This looks lovely! I'm not particularly qualified to review the implementation of the frontend code, but I left a couple very minor suggestions on the text we display in the UI. Thanks for all your work on getting this exposed in the console, it looks great!

app/pages/project/instances/instance/tabs/SettingsTab.tsx

Co-authored-by: Eliza Weisman <[email protected]>

hawkw · 2025-02-07T18:51:36Z

app/api/util.ts

+  // not all updates are restricted by state
+
+  // resize means changes to ncpus and memory
+  // https://github.com/oxidecomputer/omicron/blob/0c6ab099e/nexus/db-queries/src/db/datastore/instance.rs#L1282-L1288
+  // https://github.com/oxidecomputer/omicron/blob/0c6ab099e/nexus/db-model/src/instance_state.rs#L39-L42
+  resize: ['stopped', 'failed', 'creating'],
+
+  // https://github.com/oxidecomputer/omicron/blob/0c6ab099e/nexus/db-queries/src/db/datastore/instance.rs#L1209-L1215
+  updateBootDisk: ['stopped', 'failed', 'creating'],
+
+  // there are no state restrictions on setting the auto restart policy, so we
+  // don't have a helper for it
+  // https://github.com/oxidecomputer/omicron/blob/0c6ab099e/nexus/db-queries/src/db/datastore/instance.rs#L1050-L1058


oxidecomputer/console@93c5abc...2720e14 * [2720e146](oxidecomputer/console@2720e146) oxidecomputer/console#2644

benjaminleonard added 2 commits January 9, 2025 11:53

First pass instance auto-restart

f66afff

Merge branch 'main' into instance-auto-restart

945b0bb

benjaminleonard commented Jan 9, 2025

View reviewed changes

app/components/DocsPopover.tsx Show resolved Hide resolved

benjaminleonard commented Jan 9, 2025

View reviewed changes

app/pages/project/instances/instance/tabs/SettingsTab.tsx Outdated Show resolved Hide resolved

benjaminleonard commented Jan 9, 2025

View reviewed changes

app/pages/project/instances/instance/tabs/SettingsTab.tsx Show resolved Hide resolved

benjaminleonard commented Jan 9, 2025

View reviewed changes

app/components/InstanceAutoRestartPopover.tsx Outdated Show resolved Hide resolved

david-crespo reviewed Jan 9, 2025

View reviewed changes

app/components/InstanceAutoRestartPopover.tsx Outdated Show resolved Hide resolved

hawkw reviewed Jan 9, 2025

View reviewed changes

app/pages/project/instances/instance/tabs/SettingsTab.tsx Outdated Show resolved Hide resolved

app/pages/project/instances/instance/tabs/SettingsTab.tsx Outdated Show resolved Hide resolved

Add comma to settings help text

3be8500

Co-authored-by: Eliza Weisman <[email protected]>

vercel bot deployed to Preview January 9, 2025 17:37 View deployment

benjaminleonard added 4 commits January 14, 2025 11:48

Add cooldown and add copy tweaks

8d40e2f

Add license

bf37c96

Change none to default in listbox text

d81c471

Update mock handler to match omicron

06400f8

vercel bot deployed to Preview January 14, 2025 12:11 View deployment

Use useInterval hook

a11042a

vercel bot deployed to Preview January 14, 2025 12:57 View deployment

Use design-system icon

c03afd2

vercel bot deployed to Preview January 14, 2025 14:05 View deployment

Text tweak

3212357

vercel bot deployed to Preview January 14, 2025 14:29 View deployment

benjaminleonard added 2 commits January 14, 2025 14:39

Simplify helpTextState

7ada68e

InstanceAutoRestartPolicy can be undefined

a599745

benjaminleonard marked this pull request as ready for review January 14, 2025 14:42

vercel bot deployed to Preview January 14, 2025 14:42 View deployment

Merge branch 'main' into instance-auto-restart

c773c3a

vercel bot deployed to Preview January 14, 2025 14:44 View deployment

Vitest fixes

467b58e

vercel bot deployed to Preview January 14, 2025 14:50 View deployment

david-crespo added 2 commits February 6, 2025 23:44

bump API client generator for date parsing fix

d9a97c6

format dates for locale with existing helper

db52d77

david-crespo mentioned this pull request Feb 7, 2025

chore(deps): update dependency @oxide/openapi-gen-ts to ~0.6.0 #2680

Closed

1 task

take enabled out of settings form

2547ecc

vercel bot deployed to Preview February 7, 2025 17:32 View deployment

handle auto restart stuff in msw at update time

e2a231d

david-crespo force-pushed the instance-auto-restart branch from 99997ee to e2a231d Compare February 7, 2025 17:44

vercel bot deployed to Preview February 7, 2025 17:44 View deployment

update mock API to allow policy update any time

690b788

vercel bot deployed to Preview February 7, 2025 18:24 View deployment

hawkw reviewed Feb 7, 2025

View reviewed changes

vercel bot deployed to Preview February 10, 2025 18:02 View deployment

david-crespo mentioned this pull request Feb 10, 2025

Cap how long an instance can poll for #2376

Closed

david-crespo added 2 commits February 10, 2025 12:13

copy tweaks, fill in tests

fad694b

poll slower for failed instances

d707200

david-crespo force-pushed the instance-auto-restart branch from 04bfec5 to d707200 Compare February 10, 2025 19:03

vercel bot deployed to Preview February 10, 2025 19:03 View deployment

vercel bot deployed to Preview February 10, 2025 22:48 View deployment

david-crespo added 3 commits February 10, 2025 17:09

simplify FormMeta, no Label needed

a3871c2

fix up polling and popover logic

a641b89

copy and popover state polish, more e2es

7cde120

david-crespo force-pushed the instance-auto-restart branch from 425524b to 7cde120 Compare February 11, 2025 18:37

vercel bot deployed to Preview February 11, 2025 18:37 View deployment

instanceAutoRestartingSoon helper

6c413e9

vercel bot deployed to Preview February 11, 2025 19:06 View deployment

david-crespo merged commit 2720e14 into main Feb 11, 2025
7 checks passed

david-crespo deleted the instance-auto-restart branch February 11, 2025 20:31

david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Feb 11, 2025

Bump web console (instance auto-restart)

a3921e7

oxidecomputer/console@93c5abc...2720e14 * [2720e146](oxidecomputer/console@2720e146) oxidecomputer/console#2644

david-crespo mentioned this pull request Feb 11, 2025

Bump web console (instance auto-restart) oxidecomputer/omicron#7520

Merged

david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Feb 11, 2025

Bump web console (instance auto-restart) (#7520)

ff9bc34

oxidecomputer/console@93c5abc...2720e14 * [2720e146](oxidecomputer/console@2720e146) oxidecomputer/console#2644

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Instance auto restart #2644

Instance auto restart #2644

Uh oh!

benjaminleonard commented Jan 9, 2025 •

edited by david-crespo

Loading

Uh oh!

vercel bot commented Jan 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hawkw left a comment

Uh oh!

Uh oh!

Uh oh!

hawkw Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

Instance auto restart #2644

Instance auto restart #2644

Uh oh!

Conversation

benjaminleonard commented Jan 9, 2025 • edited by david-crespo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hawkw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hawkw Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

benjaminleonard commented Jan 9, 2025 •

edited by david-crespo

Loading

vercel bot commented Jan 9, 2025 •

edited

Loading