Skip to content

Conversation

benjaminleonard
Copy link
Contributor

Before:
image

After:
image

Applying the border and border to the area chart directly was causing issues.

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Jan 13, 2025 4:52pm

Copy link
Collaborator

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to use the equivalent tailwind classes instead of inline styles but it’s basically the same thing.

@benjaminleonard benjaminleonard enabled auto-merge (squash) January 13, 2025 16:52
@benjaminleonard benjaminleonard merged commit 1e9d3f2 into main Jan 13, 2025
7 checks passed
@benjaminleonard benjaminleonard deleted the fix-area-chart-padding branch January 13, 2025 17:02
charliepark added a commit to oxidecomputer/omicron that referenced this pull request Jan 28, 2025
oxidecomputer/console@d583ae7...288f1c1

* [288f1c1b](oxidecomputer/console@288f1c1b) oxidecomputer/console#2670
* [7771953d](oxidecomputer/console@7771953d) oxidecomputer/console#2666
* [28ea9518](oxidecomputer/console@28ea9518) oxidecomputer/console#2576
* [0878bcc3](oxidecomputer/console@0878bcc3) oxidecomputer/console#2668
* [dacb1028](oxidecomputer/console@dacb1028) oxidecomputer/console#2667
* [b4f2a966](oxidecomputer/console@b4f2a966) oxidecomputer/console#2658
* [13a8200d](oxidecomputer/console@13a8200d) chore: upgrade vite and vitest
* [7ec7d667](oxidecomputer/console@7ec7d667) oxidecomputer/console#2664
* [ba21b682](oxidecomputer/console@ba21b682) oxidecomputer/console#2655
* [a0bc4708](oxidecomputer/console@a0bc4708) oxidecomputer/console#2660
* [287a531d](oxidecomputer/console@287a531d) oxidecomputer/console#2659
* [b73255d4](oxidecomputer/console@b73255d4) chore: use design-system 2.1.0, 3.0 is no more
* [7a8615a0](oxidecomputer/console@7a8615a0) oxidecomputer/console#2638
* [0f704717](oxidecomputer/console@0f704717) oxidecomputer/console#2637
* [1e9d3f26](oxidecomputer/console@1e9d3f26) oxidecomputer/console#2650
* [6cd25c9f](oxidecomputer/console@6cd25c9f) oxidecomputer/console#2630
* [a629300f](oxidecomputer/console@a629300f) oxidecomputer/console#2648
* [b57531d9](oxidecomputer/console@b57531d9) oxidecomputer/console#2646
* [b55e1618](oxidecomputer/console@b55e1618) oxidecomputer/console#2642
* [a3e8216e](oxidecomputer/console@a3e8216e) tools: also lint for console.log in oxlint
* [a6f84049](oxidecomputer/console@a6f84049) oxidecomputer/console#2643
* [2fa9b424](oxidecomputer/console@2fa9b424) remove stray console.log in table header
* [c2ea0e3e](oxidecomputer/console@c2ea0e3e) oxidecomputer/console#2639
* [48e1b15a](oxidecomputer/console@48e1b15a) oxidecomputer/console#2598
* [d144e7dc](oxidecomputer/console@d144e7dc) oxidecomputer/console#2617
* [c147df00](oxidecomputer/console@c147df00) oxidecomputer/console#2628
* [63954c8a](oxidecomputer/console@63954c8a) oxidecomputer/console#2633
* [aa46e508](oxidecomputer/console@aa46e508) oxidecomputer/console#2631
* [892fc2e9](oxidecomputer/console@892fc2e9) oxidecomputer/console#2629
charliepark added a commit to oxidecomputer/omicron that referenced this pull request Jan 29, 2025
oxidecomputer/console@d583ae7...288f1c1

* [288f1c1b](oxidecomputer/console@288f1c1b)
oxidecomputer/console#2670
* [7771953d](oxidecomputer/console@7771953d)
oxidecomputer/console#2666
* [28ea9518](oxidecomputer/console@28ea9518)
oxidecomputer/console#2576
* [0878bcc3](oxidecomputer/console@0878bcc3)
oxidecomputer/console#2668
* [dacb1028](oxidecomputer/console@dacb1028)
oxidecomputer/console#2667
* [b4f2a966](oxidecomputer/console@b4f2a966)
oxidecomputer/console#2658
* [13a8200d](oxidecomputer/console@13a8200d)
chore: upgrade vite and vitest
* [7ec7d667](oxidecomputer/console@7ec7d667)
oxidecomputer/console#2664
* [ba21b682](oxidecomputer/console@ba21b682)
oxidecomputer/console#2655
* [a0bc4708](oxidecomputer/console@a0bc4708)
oxidecomputer/console#2660
* [287a531d](oxidecomputer/console@287a531d)
oxidecomputer/console#2659
* [b73255d4](oxidecomputer/console@b73255d4)
chore: use design-system 2.1.0, 3.0 is no more
* [7a8615a0](oxidecomputer/console@7a8615a0)
oxidecomputer/console#2638
* [0f704717](oxidecomputer/console@0f704717)
oxidecomputer/console#2637
* [1e9d3f26](oxidecomputer/console@1e9d3f26)
oxidecomputer/console#2650
* [6cd25c9f](oxidecomputer/console@6cd25c9f)
oxidecomputer/console#2630
* [a629300f](oxidecomputer/console@a629300f)
oxidecomputer/console#2648
* [b57531d9](oxidecomputer/console@b57531d9)
oxidecomputer/console#2646
* [b55e1618](oxidecomputer/console@b55e1618)
oxidecomputer/console#2642
* [a3e8216e](oxidecomputer/console@a3e8216e)
tools: also lint for console.log in oxlint
* [a6f84049](oxidecomputer/console@a6f84049)
oxidecomputer/console#2643
* [2fa9b424](oxidecomputer/console@2fa9b424)
remove stray console.log in table header
* [c2ea0e3e](oxidecomputer/console@c2ea0e3e)
oxidecomputer/console#2639
* [48e1b15a](oxidecomputer/console@48e1b15a)
oxidecomputer/console#2598
* [d144e7dc](oxidecomputer/console@d144e7dc)
oxidecomputer/console#2617
* [c147df00](oxidecomputer/console@c147df00)
oxidecomputer/console#2628
* [63954c8a](oxidecomputer/console@63954c8a)
oxidecomputer/console#2633
* [aa46e508](oxidecomputer/console@aa46e508)
oxidecomputer/console#2631
* [892fc2e9](oxidecomputer/console@892fc2e9)
oxidecomputer/console#2629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants