-
Notifications
You must be signed in to change notification settings - Fork 13
Fixes padding bug on chart #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to use the equivalent tailwind classes instead of inline styles but it’s basically the same thing.
charliepark
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jan 28, 2025
oxidecomputer/console@d583ae7...288f1c1 * [288f1c1b](oxidecomputer/console@288f1c1b) oxidecomputer/console#2670 * [7771953d](oxidecomputer/console@7771953d) oxidecomputer/console#2666 * [28ea9518](oxidecomputer/console@28ea9518) oxidecomputer/console#2576 * [0878bcc3](oxidecomputer/console@0878bcc3) oxidecomputer/console#2668 * [dacb1028](oxidecomputer/console@dacb1028) oxidecomputer/console#2667 * [b4f2a966](oxidecomputer/console@b4f2a966) oxidecomputer/console#2658 * [13a8200d](oxidecomputer/console@13a8200d) chore: upgrade vite and vitest * [7ec7d667](oxidecomputer/console@7ec7d667) oxidecomputer/console#2664 * [ba21b682](oxidecomputer/console@ba21b682) oxidecomputer/console#2655 * [a0bc4708](oxidecomputer/console@a0bc4708) oxidecomputer/console#2660 * [287a531d](oxidecomputer/console@287a531d) oxidecomputer/console#2659 * [b73255d4](oxidecomputer/console@b73255d4) chore: use design-system 2.1.0, 3.0 is no more * [7a8615a0](oxidecomputer/console@7a8615a0) oxidecomputer/console#2638 * [0f704717](oxidecomputer/console@0f704717) oxidecomputer/console#2637 * [1e9d3f26](oxidecomputer/console@1e9d3f26) oxidecomputer/console#2650 * [6cd25c9f](oxidecomputer/console@6cd25c9f) oxidecomputer/console#2630 * [a629300f](oxidecomputer/console@a629300f) oxidecomputer/console#2648 * [b57531d9](oxidecomputer/console@b57531d9) oxidecomputer/console#2646 * [b55e1618](oxidecomputer/console@b55e1618) oxidecomputer/console#2642 * [a3e8216e](oxidecomputer/console@a3e8216e) tools: also lint for console.log in oxlint * [a6f84049](oxidecomputer/console@a6f84049) oxidecomputer/console#2643 * [2fa9b424](oxidecomputer/console@2fa9b424) remove stray console.log in table header * [c2ea0e3e](oxidecomputer/console@c2ea0e3e) oxidecomputer/console#2639 * [48e1b15a](oxidecomputer/console@48e1b15a) oxidecomputer/console#2598 * [d144e7dc](oxidecomputer/console@d144e7dc) oxidecomputer/console#2617 * [c147df00](oxidecomputer/console@c147df00) oxidecomputer/console#2628 * [63954c8a](oxidecomputer/console@63954c8a) oxidecomputer/console#2633 * [aa46e508](oxidecomputer/console@aa46e508) oxidecomputer/console#2631 * [892fc2e9](oxidecomputer/console@892fc2e9) oxidecomputer/console#2629
charliepark
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jan 29, 2025
oxidecomputer/console@d583ae7...288f1c1 * [288f1c1b](oxidecomputer/console@288f1c1b) oxidecomputer/console#2670 * [7771953d](oxidecomputer/console@7771953d) oxidecomputer/console#2666 * [28ea9518](oxidecomputer/console@28ea9518) oxidecomputer/console#2576 * [0878bcc3](oxidecomputer/console@0878bcc3) oxidecomputer/console#2668 * [dacb1028](oxidecomputer/console@dacb1028) oxidecomputer/console#2667 * [b4f2a966](oxidecomputer/console@b4f2a966) oxidecomputer/console#2658 * [13a8200d](oxidecomputer/console@13a8200d) chore: upgrade vite and vitest * [7ec7d667](oxidecomputer/console@7ec7d667) oxidecomputer/console#2664 * [ba21b682](oxidecomputer/console@ba21b682) oxidecomputer/console#2655 * [a0bc4708](oxidecomputer/console@a0bc4708) oxidecomputer/console#2660 * [287a531d](oxidecomputer/console@287a531d) oxidecomputer/console#2659 * [b73255d4](oxidecomputer/console@b73255d4) chore: use design-system 2.1.0, 3.0 is no more * [7a8615a0](oxidecomputer/console@7a8615a0) oxidecomputer/console#2638 * [0f704717](oxidecomputer/console@0f704717) oxidecomputer/console#2637 * [1e9d3f26](oxidecomputer/console@1e9d3f26) oxidecomputer/console#2650 * [6cd25c9f](oxidecomputer/console@6cd25c9f) oxidecomputer/console#2630 * [a629300f](oxidecomputer/console@a629300f) oxidecomputer/console#2648 * [b57531d9](oxidecomputer/console@b57531d9) oxidecomputer/console#2646 * [b55e1618](oxidecomputer/console@b55e1618) oxidecomputer/console#2642 * [a3e8216e](oxidecomputer/console@a3e8216e) tools: also lint for console.log in oxlint * [a6f84049](oxidecomputer/console@a6f84049) oxidecomputer/console#2643 * [2fa9b424](oxidecomputer/console@2fa9b424) remove stray console.log in table header * [c2ea0e3e](oxidecomputer/console@c2ea0e3e) oxidecomputer/console#2639 * [48e1b15a](oxidecomputer/console@48e1b15a) oxidecomputer/console#2598 * [d144e7dc](oxidecomputer/console@d144e7dc) oxidecomputer/console#2617 * [c147df00](oxidecomputer/console@c147df00) oxidecomputer/console#2628 * [63954c8a](oxidecomputer/console@63954c8a) oxidecomputer/console#2633 * [aa46e508](oxidecomputer/console@aa46e508) oxidecomputer/console#2631 * [892fc2e9](oxidecomputer/console@892fc2e9) oxidecomputer/console#2629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:

After:

Applying the border and border to the area chart directly was causing issues.