Adjust metrics side tabs spacing #2724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
Mar 3, 2025
david-crespo
reviewed
Mar 3, 2025
| </div> | ||
| </PageHeader> | ||
| <PropertiesTable columns={2} className="-mt-8 mb-16"> | ||
| <PropertiesTable columns={2} className="-mt-8 mb-8"> |
There was a problem hiding this comment.
The fact that they all have this makes me wonder if it should be formalized somehow, but it doesn't really matter to me.
david-crespo
approved these changes
Mar 3, 2025
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 4, 2025
oxidecomputer/console@a3566bd...eed4a4e * [eed4a4e7](oxidecomputer/console@eed4a4e7) gitigore .react-router/ * [a8ac33f6](oxidecomputer/console@a8ac33f6) design-system 2.3 for icon build rework * [b50269c3](oxidecomputer/console@b50269c3) oxidecomputer/console#2743 * [d07c69ca](oxidecomputer/console@d07c69ca) oxidecomputer/console#2744 * [59818128](oxidecomputer/console@59818128) oxidecomputer/console#2741 * [1fe4a7ec](oxidecomputer/console@1fe4a7ec) minor: remove indirection in router edit onDismiss * [718244d2](oxidecomputer/console@718244d2) minor: redirectWithLoader helper * [0db9e4c8](oxidecomputer/console@0db9e4c8) oxidecomputer/console#2720 * [97869a79](oxidecomputer/console@97869a79) oxidecomputer/console#2731 * [bca35b85](oxidecomputer/console@bca35b85) debug ci e2e script uses fzf * [516a375d](oxidecomputer/console@516a375d) oxidecomputer/console#2727 * [873e898f](oxidecomputer/console@873e898f) oxidecomputer/console#2724 * [46f14c21](oxidecomputer/console@46f14c21) oxidecomputer/console#2729 * [a64dbb8a](oxidecomputer/console@a64dbb8a) oxidecomputer/console#2723 * [7410850d](oxidecomputer/console@7410850d) chore: fix lint error, sorry * [6985f5dd](oxidecomputer/console@6985f5dd) oxidecomputer/console#2708 * [abcda05b](oxidecomputer/console@abcda05b) tools: deploy dogfood script accepts any git ref
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 4, 2025
oxidecomputer/console@a3566bd...eed4a4e * [eed4a4e7](oxidecomputer/console@eed4a4e7) gitigore .react-router/ * [a8ac33f6](oxidecomputer/console@a8ac33f6) design-system 2.3 for icon build rework * [b50269c3](oxidecomputer/console@b50269c3) oxidecomputer/console#2743 * [d07c69ca](oxidecomputer/console@d07c69ca) oxidecomputer/console#2744 * [59818128](oxidecomputer/console@59818128) oxidecomputer/console#2741 * [1fe4a7ec](oxidecomputer/console@1fe4a7ec) minor: remove indirection in router edit onDismiss * [718244d2](oxidecomputer/console@718244d2) minor: redirectWithLoader helper * [0db9e4c8](oxidecomputer/console@0db9e4c8) oxidecomputer/console#2720 * [97869a79](oxidecomputer/console@97869a79) oxidecomputer/console#2731 * [bca35b85](oxidecomputer/console@bca35b85) debug ci e2e script uses fzf * [516a375d](oxidecomputer/console@516a375d) oxidecomputer/console#2727 * [873e898f](oxidecomputer/console@873e898f) oxidecomputer/console#2724 * [46f14c21](oxidecomputer/console@46f14c21) oxidecomputer/console#2729 * [a64dbb8a](oxidecomputer/console@a64dbb8a) oxidecomputer/console#2723 * [7410850d](oxidecomputer/console@7410850d) chore: fix lint error, sorry * [6985f5dd](oxidecomputer/console@6985f5dd) oxidecomputer/console#2708 * [abcda05b](oxidecomputer/console@abcda05b) tools: deploy dogfood script accepts any git ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tightened top margins and fixes #2709