Affinity group add/remove on instance settings tab #2789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Apr 8, 2025
| onDismiss() | ||
| queryClient.invalidateEndpoint('antiAffinityGroupMemberList') | ||
| queryClient.invalidateEndpoint('antiAffinityGroupView') | ||
| queryClient.invalidateEndpoint('instanceAntiAffinityGroupList') |
There was a problem hiding this comment.
This is kind of annoying — any time group memberships change, we have to clear cache on both endpoints.
david-crespo
commented
Apr 8, 2025
| const nonMemberGroups = useMemo( | ||
| () => R.differenceWith(allGroups.items, memberGroups.items, (a, b) => a.id === b.id), | ||
| [memberGroups, allGroups] | ||
| ) |
There was a problem hiding this comment.
how cool is differenceWith
david-crespo
commented
Apr 8, 2025
| const actions = makeActions(row.original) | ||
| const id = typeof row.original.id === 'string' ? row.original.id : null | ||
| return <RowActions id={id} actions={actions} /> | ||
| return <RowActions id={id} actions={actions} copyIdLabel={copyIdLabel} /> |
There was a problem hiding this comment.
The changes in this file let us hook into this copy ID column logic while overriding the name to say Copy group ID because otherwise it's not clear what the ID is of.
|
A little better. I thought about changing the button to 
|
charliepark
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Solid. Added some "disable the ADD button" logic in #2792, but this looks good.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 9, 2025
oxidecomputer/console@3e5a0a1...d906190 * [d9061901](oxidecomputer/console@d9061901) oxidecomputer/console#2795 * [8e509d99](oxidecomputer/console@8e509d99) oxidecomputer/console#2793 * [2ef6e7a1](oxidecomputer/console@2ef6e7a1) oxidecomputer/console#2790 * [04aceb5a](oxidecomputer/console@04aceb5a) oxidecomputer/console#2789 * [1ecc5690](oxidecomputer/console@1ecc5690) oxidecomputer/console#2791
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 9, 2025
oxidecomputer/console@3e5a0a1...3db0150 * [3db0150d](oxidecomputer/console@3db0150d) oxidecomputer/console#2796 * [d9061901](oxidecomputer/console@d9061901) oxidecomputer/console#2795 * [8e509d99](oxidecomputer/console@8e509d99) oxidecomputer/console#2793 * [2ef6e7a1](oxidecomputer/console@2ef6e7a1) oxidecomputer/console#2790 * [04aceb5a](oxidecomputer/console@04aceb5a) oxidecomputer/console#2789 * [1ecc5690](oxidecomputer/console@1ecc5690) oxidecomputer/console#2791
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 9, 2025
oxidecomputer/console@3e5a0a1...3db0150 * [3db0150d](oxidecomputer/console@3db0150d) oxidecomputer/console#2796 * [d9061901](oxidecomputer/console@d9061901) oxidecomputer/console#2795 * [8e509d99](oxidecomputer/console@8e509d99) oxidecomputer/console#2793 * [2ef6e7a1](oxidecomputer/console@2ef6e7a1) oxidecomputer/console#2790 * [04aceb5a](oxidecomputer/console@04aceb5a) oxidecomputer/console#2789 * [1ecc5690](oxidecomputer/console@1ecc5690) oxidecomputer/console#2791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2771
Feels a little
maybe needs one fewer "anti-affinity".