-
Notifications
You must be signed in to change notification settings - Fork 13
Add snat to external ips #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snat to external ips #2868
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…nt off because of shared IPs
Have fixed this. |
@bnaecker suggests we should filter out the SNAT IP here. I think that's a good idea. (In this case it's not showing because it's third in the list and we only show 2.) ![]() console/app/components/ExternalIps.tsx Lines 25 to 29 in ef73c18
|
// Include SNAT IPs in IP utilization calculation, deduplicating by IP address | ||
// since multiple instances can share the same SNAT IP with different port ranges | ||
const uniqueSnatIps = [...new Set(db.snatIps.map((sip) => sip.external_ip.ip))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to call out that this is where we handle the SNAT IP address de-duplication (de-quadification?). Essentially, only pull unique IPs, and use that for the utilization count.
2105ef1
to
9da7360
Compare
9da7360
to
20901f7
Compare
f1cfb39
to
111a295
Compare
oxidecomputer/console@bcfd938...e40d1ea * [e40d1ea0](oxidecomputer/console@e40d1ea0) oxidecomputer/console#2873 * [0928d245](oxidecomputer/console@0928d245) oxidecomputer/console#2868 * [29599677](oxidecomputer/console@29599677) oxidecomputer/console#2872 * [ef73c18e](oxidecomputer/console@ef73c18e) oxidecomputer/console#2863
oxidecomputer/console@bcfd938...e40d1ea * [e40d1ea0](oxidecomputer/console@e40d1ea0) oxidecomputer/console#2873 * [0928d245](oxidecomputer/console@0928d245) oxidecomputer/console#2868 * [29599677](oxidecomputer/console@29599677) oxidecomputer/console#2872 * [ef73c18e](oxidecomputer/console@ef73c18e) oxidecomputer/console#2863
This adds SNAT IPs to the list of an instance's external IPs. This is the console counterpart to oxidecomputer/omicron#8685. We're still talking through a few design decisions around ports, but I wanted to get a PR going for it.
Closes #2866