[nexus] Make Instance Deletion actually idempotent #7556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
changed the title
smklein
changed the title
hawkw
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Nice catch with this one! The new code feels substantially less sketchy to me.
I left a few nitpicky comments, but I have no major concerns about the change and would like to see this landed! I notice that this is currently stacked on top of your affinity work --- would it make sense to base this branch on main instead and land the fix before the affinity stuff?
smklein
force-pushed
the
safer-instance-deletion
branch
from
c428650 to
83516c8
Compare
smklein
changed the title
Sure thing, pulled it out, will merge first |
hawkw
approved these changes
Feb 19, 2025
hawkw
pushed a commit
that referenced
this pull request
Feb 21, 2025
Marking an instance deleted, within the "instance deletion saga", invokes `datastore.project_delete_instance`. This API performs the following tasks: 1. Marks the instance record "Destroyed", and detaches all disks 2. Performs a variety of other cleanup tasks (deleting SSH keys, not-yet-but-soon cleaning up affinity groups, marking migrations as deleted). These operations are not in a transaction, so it's possible for step (1) to succeed, but step (2) to not happen. In this case, it's critical that a second invocation of this API be able to actually perform cleanup. This PR adjusts the implementation of `project_delete_instance` to make this actually true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking an instance deleted, within the "instance deletion saga", invokes
datastore.project_delete_instance.This API performs the following tasks:
These operations are not in a transaction, so it's possible for step (1) to succeed, but step (2) to not happen.
In this case, it's critical that a second invocation of this API be able to actually perform cleanup.
This PR adjusts the implementation of
project_delete_instanceto make this actually true.