Planner tests conversion CLI tests, for nexus generation testing #9108
Conversation
smklein
changed the title
smklein
changed the title
| set 0 explicit active Nexus zones | ||
|
|
||
| > blueprint-plan latest latest | ||
| error: failed to construct planning input: no Nexus zones found at current active generation (1) |
There was a problem hiding this comment.
Technically this output is coming from the reconfigurator-cli, but, even if it wasn't, the planner would throw a similar error.
| # I wish there was a less painful way of doing this! | ||
| # Manually update the: | ||
| # - RT Bootloader | ||
| # - ROT | ||
| # - SP | ||
| # - Host Phase 1 | ||
| # - Host Phase 2 | ||
| # | ||
| # To match what is requested by the blueprint. |
There was a problem hiding this comment.
Yes! This just came up on #9044 (comment) too. I'll file an issue.
| blueprint-diff latest | ||
|
|
||
| # If we expunge one of the OLD nexuses, we should observe | ||
| # that it is re-created. |
There was a problem hiding this comment.
Great addition to this test 👍
| set active-nexus-gen 2 | ||
|
|
||
| # Now expungement can complete | ||
| # (Three Nexuses, expunged one at a time) |
There was a problem hiding this comment.
We're not regenerating inventory from each of these, so I guess the planner isn't waiting for the first expungement before proceeding to the second and so on? Seems fine, but - could the planner expunge all three in one step? (I could imagine this being trivial or really painful depending on how that bit of the planner is structured, but I haven't looked.)
There was a problem hiding this comment.
I think that's correct - I think the planner just happens to be bailing out after the first one.
If it's cool with you, I'm going to punt this to a follow-up -- it would be a planner behavior change (which is fine!) but probably shouldn't be part of this PR
There was a problem hiding this comment.
Yeah, definitely! Sorry, should've made it clear that was more of a "huh, is this what we want?" question than a request for changes on this PR.
2 participants
In response to #8936 (comment), this PR migrates planner tests for nexus generation testing to use the reconfigurator-cli.
To make this possible, the reconfigurator-cli has been modified to allow the caller to modify the set of
activeandnot_yetNexus zones explicitly. In production, these values would be read from the database, and populated by the executor. Before this PR, these values were inferred by the reconfigurator simulator, based on the target blueprint.