fix: Remove old account data before creating FK constraints #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 10 -> 11 database migration adds FK constraints with `AccountEntity.id` as the parent. Because of previous bugs there may be orphaned data in some tables that references accounts that no longer exist in `AccountEntity`. This causes a crash during migration. This migration was previously automatic. Rewrite it to be manual, by copying the code that was previously generated and inserting explcit `DELETE` statements ahead of the migration to remove the orphaned rows. Fixes pachli#1320
nikclayton
commented
Mar 1, 2025
core/database/src/main/kotlin/app/pachli/core/database/AppDatabase.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 10 -> 11 database migration adds FK constraints with
AccountEntity.idas the parent.Because of previous bugs there may be orphaned data in some tables that references accounts that no longer exist in
AccountEntity. This causes a crash during migration.This migration was previously automatic. Rewrite it to be manual, by copying the code that was previously generated and inserting explcit
DELETEstatements ahead of the migration to remove the orphaned rows.Fixes #1320