fix: Create filters with the correct content-type #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content filters are created with a form-encoded POST request. The Mastodon API defines these in a way that can't be replicated with Retrofit's normal mechanisms for defining an API (including using the `@FormUrlEncoded annotation`), so `NewContentFilterConverterFactory` converts the `NewContentFilter` object to the body of the request. However, for some servers (at least, GoToSocial) the content-type header is required. That's normally provided by the `@FormUrlEncoded` annotation, but that can't be used here. So provide the header directly in the API definition. Fixes pachli#1375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content filters are created with a form-encoded POST request. The Mastodon API defines these in a way that can't be replicated with Retrofit's normal mechanisms for defining an API (including using the
@FormUrlEncoded annotation), soNewContentFilterConverterFactoryconverts theNewContentFilterobject to the body of the request.However, for some servers (at least, GoToSocial) the content-type header is required. That's normally provided by the
@FormUrlEncodedannotation, but that can't be used here.So provide the header directly in the API definition.
Fixes #1375