-
-
Notifications
You must be signed in to change notification settings - Fork 154
Add some missing Optional type annotations to interval_range and read_sql
#1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
595ca71 to
93fac58
Compare
Dr-Irv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to fix the other defaults for read_sql() that would be good as well, but not a problem if you don't.
interval_range and read_sql
Yes, that's fine. |
Dr-Irv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarcoGorelli
These are some cases where the overloads indicate that they are meant to match the parameter defaults, which in all these cases are
= None. However,Noneis currently missing from the annotations for these parametersassert_type()to assert the type of any return value