Skip to content

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Apr 22, 2019

xref #26189

@jreback jreback added Testing pandas testing functions or related to the test suite Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Apr 22, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 22, 2019
@jreback
Copy link
Contributor Author

jreback commented Apr 22, 2019

cc @WillAyd this should over the failing numpy-dev build issue

@WillAyd
Copy link
Member

WillAyd commented Apr 23, 2019

Makes sense. lgtm if green

@jreback
Copy link
Contributor Author

jreback commented Apr 23, 2019

this will still fail on the doc-string validation issue (your PR is fixing)

@WillAyd
Copy link
Member

WillAyd commented Apr 23, 2019

Yea meant excluding that. Looks like there's something else I need to fix in that PR so feel free to merge this in advance

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26190 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26190      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52371    52371              
==========================================
- Hits        48175    48172       -3     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.71% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecee8f...ac6b7c6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #26190 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26190      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52371    52371              
==========================================
- Hits        48175    48172       -3     
- Misses       4196     4199       +3
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.71% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecee8f...ac6b7c6. Read the comment docs.

@jreback jreback merged commit e134ddb into pandas-dev:master Apr 23, 2019
jreback added a commit to jreback/pandas that referenced this pull request Apr 28, 2019
jreback added a commit that referenced this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants