TPY: Add Types to gbq.py #30632
TPY: Add Types to gbq.py #30632
Conversation
| query: str, | ||
| project_id: Optional[str] = None, | ||
| index_col: Optional[str] = None, | ||
| col_order: Optional[List[str]] = None, |
There was a problem hiding this comment.
Does this explicitly need to be a List or does Sequence work as well?
There was a problem hiding this comment.
Ahh good point - tried the other basic sequence types and they throw. Since it's used to retrieve columns from a DataFrame. Like df[col_order]. So think List it is!
pandas/io/gbq.py
Outdated
| auth_local_webserver: bool = False, | ||
| dialect: Optional[str] = None, | ||
| location: Optional[str] = None, | ||
| configuration: Optional[Dict] = None, |
There was a problem hiding this comment.
Can subtypes be added for Dict here?
There was a problem hiding this comment.
Added Dict[str, Any] since it is essentially key value pairs that are sent to the GBQ api. Unsure if we can be any stricter on the values?
https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.query
|
thanks @alimcmaster1 you might want to push these annotations to pandas-gbq as well |
Thanks will do! |
3 participants
Add Types to args for
to_gbqandread_gbq.