TST: GroupBy(..., as_index=True).agg() drops index #33098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
changed the title
jreback
added
Groupby
Testing
jreback
requested changes
Mar 31, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
thanks, a couple of comments, ping on green.
Member
|
Mind merging master? Failing test should be fixed |
…641_add_test � Conflicts: � pandas/tests/groupby/test_categorical.py
Member
Author
|
Merge master |
jreback
changed the title
jreback
approved these changes
Jun 14, 2020
Contributor
|
looks fine, can you merge master and ping on green. |
Contributor
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffWhile searching for related issue for my other pull request, I found that this issue must have been fixed with another commit in the past (don't know when this issue was fixed).
I added a test to ensure that this error won't know occur in the future.