BUG: Allow plain bools in ExtensionArray.equals #34661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Bug
ExtensionArray
jorisvandenbossche
approved these changes
Jun 9, 2020
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Thanks, looks good to me!
|
|
||
|
|
||
| def test_basic_equals(data): | ||
| assert pd.Series(data).equals(pd.Series(data)) |
Member
There was a problem hiding this comment.
There is a BaseMethodsTests test_equals that could in theory be reused here. But since none of the other methods are implemented, we would need to skip all other tests, which would be a bit onerous. So fine with a custom test.
Co-authored-by: Joris Van den Bossche <[email protected]>
jreback
requested changes
Jun 9, 2020
pandas/core/arrays/base.py
Outdated
| return (equal_values | equal_na).all().item() | ||
| result = (equal_values | equal_na).all() | ||
|
|
||
| if isinstance(result, np.bool_): |
Contributor
Author
There was a problem hiding this comment.
Addressed and CI passed.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff