DOC: inline docstrings for read_excel and storage options in io/excel… #63193
+332
−284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/base.py. with Ruff formatting fixes
rhshadrach
requested changes
Nov 25, 2025
pandas/io/excel/_base.py
Outdated
Comment on lines
1003
to
1004
| storage_options : dict, optional | ||
| Extra options that make sense for a particular storage connection, e.g. |
Member
There was a problem hiding this comment.
For this and the two instance below, can you indent the body description as is done for other parameters.
Author
There was a problem hiding this comment.
Absolutely, sorry I got busy and am just now getting back to work on the failing checks.
Author
There was a problem hiding this comment.
I have updated this as asked for, I am still failing two checks, but I am unsure why, I copied the docstrings as suggested originally and I have only made linting and requested changes since then, any advice would be appreciated!
rhshadrach
requested changes
Dec 2, 2025
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
I think it's just an indentation issue.
pandas/io/excel/_base.py
Outdated
Comment on lines
367
to
369
| If used in conjunction with ``parse_dates``, will parse dates according to this | ||
| format. For anything more complex, | ||
| please read in as ``object`` and then apply :func:`to_datetime` as-needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed usage of the
@Appenderand@docdecorators for read_excel and storage_options, replacing them with inline docstrings for pandas/io/excel/_base.py.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.