Fixed alignemnt pattern position array order #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to share a fix for QR code generation in case you are open to contributions:
Fixing an issue where the QR alignment pattern position array is not created in ascending order. When the array is out-of-order, this breaks the array ordering assumption in
qrCode.draw.brs:_qrCode_draw_drawFunctionPatterns
that prevents alignment patterns being generated over finder patterns. This results in the drawn QR code being invalid (for large encoded text size) and not scannable with a QR code scanner.qrCode.draw.brs:_qrCode_draw_drawFunctionPatterns:
Additionally removed the
splice
function since it was not used anywhere else in the code.