Skip to content

Conversation

@grantland
Copy link
Contributor

OfflineQueryLogic was missing the proper code path to compare
a value against a JSONArray.

Added tests for comparing a value against a List.

@grantland grantland added type:bug Impaired feature or lacking behavior that is likely assumed needs review labels Aug 13, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test .whereEqualTo("list", 4) and make sure it returns false.

@hallucinogen
Copy link
Contributor

LGTM. One nits

`OfflineQueryLogic` was missing the proper code path to compare
a value against a `JSONArray`.

Added tests for comparing a value against a `List`.
@grantland grantland force-pushed the grantland.lds_jsonarray branch from d36a577 to 4fba2cc Compare August 14, 2015 19:34
grantland added a commit that referenced this pull request Aug 14, 2015
Fix querying for a ParseObject with JSONArray key
@grantland grantland merged commit ac5db47 into master Aug 14, 2015
@grantland grantland deleted the grantland.lds_jsonarray branch August 14, 2015 19:36
@grantland grantland modified the milestone: 1.10.1 Aug 18, 2015
@facebook-github-bot
Copy link

@grantland updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Impaired feature or lacking behavior that is likely assumed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants