Rename PFFile and PFLogger #1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woildan
force-pushed
the
rename-PFFile-and-PFLogger
branch
from
69a8ebd to
e607a36
Compare
Contributor
|
Can you check the tests that failed? |
Contributor
Author
|
Tests that failed are KeychainStoreTests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the fix for #1325 so I took the liberty to use @RyanBertrand's branch and submit it in this PR.
All I did is fix the path of a renamed file in the xcodeproj, change some comments and rewrite the commits history.
I'm not familiar with the development procedure of the Parse SDK, but it builds on my machine, tests are green and the SDK works in my app.