Skip to content

perf: Skip registering auth delegate if it's already registered #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2023
Merged

perf: Skip registering auth delegate if it's already registered #1715

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19563aa
fix
mtrezza Feb 26, 2023
bcd7817
Update PFUserAuthenticationController.m
mtrezza Feb 26, 2023
ed16f0f
Update PFUserAuthenticationController.m
mtrezza Feb 26, 2023
4d186d4
Update PFUserAuthenticationController.m
mtrezza Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...e/Parse/Internal/User/AuthenticationProviders/Controller/PFUserAuthenticationController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,19 @@ - (void)registerAuthenticationDelegate:(id<PFUserAuthenticationDelegate>)delegat
PFParameterAssert(delegate, @"Authentication delegate can't be `nil`.");
PFParameterAssert(authType, @"`authType` can't be `nil`.");

// If auth delete is already registered then unregister it gracefully
// If auth delete is already registered for provider
if ([self authenticationDelegateForAuthType:authType]) {

// If same auth delete is already registered then don't register it again
if ([self authenticationDelegateForAuthType:authType] == delegate) {
NSLog(@"skipping registering as same delegate already registered for authType `%@`.", authType);
return;
}

NSLog(@"unregistering existing deletegate to gracefully register new delegate for authType `%@`.", authType);
[self unregisterAuthenticationDelegateForAuthType:authType];
}

dispatch_sync(_dataAccessQueue, ^{
self->_authenticationDelegates[authType] = delegate;
});
Expand Down